Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

By default embeding content from calmPress should be off #246

Closed
markkap opened this issue Apr 23, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@markkap
Copy link

commented Apr 23, 2019

It is hard to spot the usage of this feature in the wild. Techcrunch right now uses it to embed excerpts from old content into a new one, but this is not the only way to implement such a thing.

A more interesting use case is embedding content between sites on a network.

It is tempting to move this feature to a core plugin, but since people might expect the relevant URLs to work, and there is no real way to indicate to an admin that he needs to install a plugin to make the feature work, just going to add a UI to turn the feature off and on, with the default being off.

@markkap markkap added this to the 1.0.0 milestone Apr 23, 2019

markkap added a commit that referenced this issue Apr 25, 2019

markkap added a commit that referenced this issue Apr 25, 2019

markkap added a commit that referenced this issue Apr 25, 2019

Do not execute embedding related code when embedding is off, no disco…
…very links, no rest api support, and misc functionality #246

markkap added a commit that referenced this issue Apr 25, 2019

A more naunced approch is required to disable the various artifacts o…
…f embedding support, as the naive on fails badly with unit tests as in them core is loaded only once and it is not wise to readd filters #246

markkap added a commit that referenced this issue Apr 25, 2019

markkap added a commit that referenced this issue Apr 25, 2019

markkap added a commit that referenced this issue Apr 25, 2019

markkap added a commit that referenced this issue Apr 25, 2019

markkap added a commit that referenced this issue Apr 25, 2019

markkap added a commit that referenced this issue Apr 26, 2019

markkap added a commit that referenced this issue Apr 26, 2019

@markkap markkap closed this Apr 26, 2019

markkap added a commit that referenced this issue Apr 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.