Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace salt generation by wordpress.org with one generated by calmpress.org #60

Closed
markkap opened this issue Sep 19, 2018 · 1 comment
Closed

Comments

@markkap
Copy link

@markkap markkap commented Sep 19, 2018

Nothing wrong with the wordpress.org salts, just reduce dependence over it.

@markkap markkap added this to the 1.0.0 milestone Sep 19, 2018
@markkap
Copy link
Author

@markkap markkap commented Sep 20, 2018

OTOH maybe just use PHP random generation for it. While the recommended http://php.net/manual/en/function.random-int.php is available only since 7.0, the threat is overblown for most sites and using a lesser functions for PHP versions before 7.0 might be acceptable.

markkap added a commit that referenced this issue Oct 17, 2018
markkap added a commit that referenced this issue Oct 17, 2018
@markkap markkap closed this Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant