Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wp-config-sample.php should not have a php extension/be "executable" #69

Closed
markkap opened this issue Sep 22, 2018 · 1 comment
Closed

wp-config-sample.php should not have a php extension/be "executable" #69

markkap opened this issue Sep 22, 2018 · 1 comment
Labels
Milestone

Comments

@markkap
Copy link

@markkap markkap commented Sep 22, 2018

While it is unlikely that there will be any major bug in that file, there is zero harm in playing it safe by changing the file to something like wp-config-sample.conf

@markkap markkap added this to the 1.0.0 milestone Sep 22, 2018
@markkap markkap changed the title wp-config-sample.php should not have a php extension/be "executable wp-config-sample.php should not have a php extension/be "executable" Oct 10, 2018
@markkap
Copy link
Author

@markkap markkap commented Dec 6, 2018

so it is going to be wp-config.sample and moved to wp-admin.

The interesting thing about this is that the file is located at the git root and moved to its distributed location at build phase. Some additional code was there to support development on the build directory which in a way make sense but feels like an ugly hack so getting that code away for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant