Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename wp-config.php to .wp-config.php and refactor it to contain only configuration #76

Open
markkap opened this Issue Sep 24, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@markkap
Copy link

markkap commented Sep 24, 2018

This issue has two parts to it

The first and the easier is to make the configuration file not accessible from the web due to #75.

The more difficult part is to resolve the multiple personality issues the file has. While it is stated in its name that it is a config file, it actually also bootstrapping core. This by itself makes it harder for users which have no familiarity with the kinks of the file to change configuration as placing the change in a wrong place in the file might lead to it being ignored with no notice.

What we are going to do is to keep the wp-config.php file, but keep in it only a comment which refers the reader to .wp-config.php.

For people that are upgrading from WordPress by overwriting the core files we will keep doing it the old way for a long time if we can not detect the .wp-config.php file.

@markkap markkap added this to the 1.0.0 milestone Sep 24, 2018

@markkap markkap changed the title rename wp-config.php to .config.php and refactor it to contain only configuration rename wp-config.php to .wp-config.php and refactor it to contain only configuration Oct 16, 2018

@mikeschinkel

This comment has been minimized.

Copy link

mikeschinkel commented Oct 30, 2018

THIS!

This is one of my biggest issues in coming up with a standard install for WPLib Box.

I have put a lot of time and thought into this and would be very interested to collaborate with you on this.

@markkap

This comment has been minimized.

Copy link
Author

markkap commented Jan 3, 2019

Too much documentation in WordPress land instructs people to make changes to wp-config.php so instead of renaming it just going to add .htaccess rule to deny direct access to it (which is what changing to .wp-config.php was supposed to achieve)

markkap added a commit that referenced this issue Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.