Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate plain and numeric urls #83

Closed
markkap opened this Issue Sep 24, 2018 · 2 comments

Comments

Projects
None yet
1 participant
@markkap
Copy link

markkap commented Sep 24, 2018

At least in the current form plain urls of the type of ?p=123 are exposing internal data (notoriously ?author=... can expose user names) which means that at the very least it is hard to change that internal data since those URLs were already indexed by google, shared on FB, etc.

To make this kind of scheme practical there should be some mapping between internal identifiers and the relevant external use, but right now I fail to see why would anyone want to use such URL structures.

Internal number would still be used whenever they are needed for admin related tasks, just not on the "front end"

@markkap markkap added the deprecation label Sep 24, 2018

@markkap markkap added this to the 1.0.0 milestone Sep 24, 2018

@markkap

This comment has been minimized.

Copy link
Author

markkap commented Sep 25, 2018

We need to think how an upgrade from the deprecate URL structure will be done. One possibility is to deny an upgrade if such a structure is detected.

@markkap

This comment has been minimized.

Copy link
Author

markkap commented Oct 14, 2018

Will call it done in the context of 1.0 release, will punt to 2.0 to ignore the 'p' URL parameter as well

@markkap markkap closed this Oct 14, 2018

markkap added a commit that referenced this issue Dec 11, 2018

wp_rewrite::using_index_permalinks has to exists for compatibility wi…
…th jetpack and other, just hardcode it to return false #83

markkap added a commit that referenced this issue Dec 25, 2018

markkap added a commit that referenced this issue Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.