Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all classes not final #92

Closed
markkap opened this issue Sep 26, 2018 · 1 comment
Closed

Make all classes not final #92

markkap opened this issue Sep 26, 2018 · 1 comment
Labels
Milestone

Comments

@markkap
Copy link

@markkap markkap commented Sep 26, 2018

Final classes can not be inherited, which prevent mocking them for testing and other places in which you might want to generate an object in some other way than the calmPress/WordPress API. The fact that some classes are final just forces people to fork even if they do not want to.

@markkap markkap added this to the 1.0.0 milestone Sep 26, 2018
@markkap
Copy link
Author

@markkap markkap commented Oct 9, 2018

Seems like there are some functions declared final as well for whatever reason

Loading

markkap added a commit that referenced this issue Oct 9, 2018
@markkap markkap closed this Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant