From d6705bbb9dc3581f5ec03d2ed0f3efe18383e8c5 Mon Sep 17 00:00:00 2001 From: a Date: Sun, 7 May 2023 22:40:38 -0500 Subject: [PATCH] fix panic handler in NewCompressor (#987) currently if newdecompressor panics, it will return nil, nil this should make it return an error instead --- compress/decompress.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/compress/decompress.go b/compress/decompress.go index 7a2cc234a..2a2e65ee4 100644 --- a/compress/decompress.go +++ b/compress/decompress.go @@ -143,13 +143,12 @@ func SetDecompressionTableCondensity(fromBitSize int) { condensePatternTableBitThreshold = fromBitSize } -func NewDecompressor(compressedFilePath string) (*Decompressor, error) { +func NewDecompressor(compressedFilePath string) (d *Decompressor, err error) { _, fName := filepath.Split(compressedFilePath) - d := &Decompressor{ + d = &Decompressor{ filePath: compressedFilePath, fileName: fName, } - var err error defer func() { if rec := recover(); rec != nil { err = fmt.Errorf("decompressing file: %s, %+v, trace: %s", compressedFilePath, rec, dbg.Stack())