From c198e02dde8e4944e179c98b721290ff2c22d53e Mon Sep 17 00:00:00 2001 From: "R. S. Doiel" Date: Wed, 28 Jan 2026 16:08:10 -0800 Subject: [PATCH 1/3] fixes for issue 91 --- codemeta.json | 2 +- cold.1.md | 2 +- cold_reports.1.md | 2 +- directory_client.ts | 5 ++++- directory_sync.1.md | 2 +- division_people.1.md | 2 +- group_vocabulary.1.md | 2 +- htdocs/modules/directory_client.js | 2 +- journal_vocabulary.1.md | 2 +- people.ts | 2 +- people_vocabulary.1.md | 2 +- thesis_option_vocabulary.1.md | 2 +- version.ts | 2 +- 13 files changed, 16 insertions(+), 13 deletions(-) diff --git a/codemeta.json b/codemeta.json index 596ef00..35597c0 100644 --- a/codemeta.json +++ b/codemeta.json @@ -102,5 +102,5 @@ "developmentStatus": "wip", "issueTracker": "https://github.com/caltechlibrary/cold/issues", "downloadUrl": "https://github.com/caltechlibrary/cold/release/latest", - "releaseNotes": "- Implemented changes in issue #90, restricted dataset version to 2.2.0 due to bug in people_names query processing." + "releaseNotes": "- Implemented changes in issue #91\n- Minor UI view edits from release v0.0.34" } \ No newline at end of file diff --git a/cold.1.md b/cold.1.md index 20751e7..bd84584 100644 --- a/cold.1.md +++ b/cold.1.md @@ -1,4 +1,4 @@ -%cold(1) user manual | 0.0.34 e934822 +%cold(1) user manual | 0.0.34 95ba21a % R. S.Doiel % 2026-01-28 diff --git a/cold_reports.1.md b/cold_reports.1.md index 0f94982..c2a1dbf 100644 --- a/cold_reports.1.md +++ b/cold_reports.1.md @@ -1,4 +1,4 @@ -%cold_reports(1) user manual | 0.0.34 e934822 +%cold_reports(1) user manual | 0.0.34 95ba21a % R. S.Doiel % 2026-01-28 diff --git a/directory_client.ts b/directory_client.ts index ba22314..0e869af 100644 --- a/directory_client.ts +++ b/directory_client.ts @@ -32,7 +32,10 @@ function updateRecord(obj: object) { if (obj.given_name !== undefined && obj.given_name !== "") { lived_name_elem.value = obj.given_name; } - if (obj.email !== undefined && obj.email !== "") { + if ( + obj.email !== undefined && obj.email !== "" && + obj.email != "[email protected]" + ) { email_elem.value = obj.email; } if (obj.division !== undefined && obj.division !== "") { diff --git a/directory_sync.1.md b/directory_sync.1.md index cc32620..e20b9f9 100644 --- a/directory_sync.1.md +++ b/directory_sync.1.md @@ -1,4 +1,4 @@ -%directory_sync(1) user manual | 0.0.34 e934822 +%directory_sync(1) user manual | 0.0.34 95ba21a % R. S.Doiel % 2026-01-28 diff --git a/division_people.1.md b/division_people.1.md index 14f7830..c7999db 100644 --- a/division_people.1.md +++ b/division_people.1.md @@ -1,4 +1,4 @@ -%division_people(1) user manual | 0.0.34 e934822 +%division_people(1) user manual | 0.0.34 95ba21a % R. S.Doiel % 2026-01-28 diff --git a/group_vocabulary.1.md b/group_vocabulary.1.md index 93aec27..ea662ba 100644 --- a/group_vocabulary.1.md +++ b/group_vocabulary.1.md @@ -1,4 +1,4 @@ -%group_vocabulary(1) user manual | 0.0.34 e934822 +%group_vocabulary(1) user manual | 0.0.34 95ba21a % R. S.Doiel % 2026-01-28 diff --git a/htdocs/modules/directory_client.js b/htdocs/modules/directory_client.js index 56680dd..0a06662 100644 --- a/htdocs/modules/directory_client.js +++ b/htdocs/modules/directory_client.js @@ -17,7 +17,7 @@ function updateRecord(obj) { if (obj.given_name !== undefined && obj.given_name !== "") { lived_name_elem.value = obj.given_name; } - if (obj.email !== undefined && obj.email !== "") { + if (obj.email !== undefined && obj.email !== "" && obj.email != "[email protected]") { email_elem.value = obj.email; } if (obj.division !== undefined && obj.division !== "") { diff --git a/journal_vocabulary.1.md b/journal_vocabulary.1.md index 4438b10..cd3d1e3 100644 --- a/journal_vocabulary.1.md +++ b/journal_vocabulary.1.md @@ -1,4 +1,4 @@ -%journal_vocabulary(1) user manual | 0.0.34 e934822 +%journal_vocabulary(1) user manual | 0.0.34 95ba21a % R. S.Doiel % 2026-01-28 diff --git a/people.ts b/people.ts index 7e9593c..5e7683e 100644 --- a/people.ts +++ b/people.ts @@ -266,7 +266,7 @@ export class People implements PeopleInterface { (obj.given_name === undefined || obj.given_name === "") ? this.given_name = "" : this.given_name = obj.given_name as unknown as string; - (obj.email === undefined || obj.email === "") + (obj.email === undefined || obj.email === "" || obj.email === "[email protected]") ? this.email = "" : this.email = obj.email as unknown as string; (obj.archivesspace_id === undefined || obj.archivesspace_id === "") diff --git a/people_vocabulary.1.md b/people_vocabulary.1.md index 6bb99c6..5dec85c 100644 --- a/people_vocabulary.1.md +++ b/people_vocabulary.1.md @@ -1,4 +1,4 @@ -%people_vocabulary(1) user manual | 0.0.34 e934822 +%people_vocabulary(1) user manual | 0.0.34 95ba21a % R. S.Doiel % 2026-01-28 diff --git a/thesis_option_vocabulary.1.md b/thesis_option_vocabulary.1.md index 6f2c771..4e81101 100644 --- a/thesis_option_vocabulary.1.md +++ b/thesis_option_vocabulary.1.md @@ -1,4 +1,4 @@ -%thesis_option_vocabulary(1) user manual | 0.0.34 e934822 +%thesis_option_vocabulary(1) user manual | 0.0.34 95ba21a % R. S.Doiel % 2026-01-28 diff --git a/version.ts b/version.ts index dac03d0..fb17332 100644 --- a/version.ts +++ b/version.ts @@ -2,7 +2,7 @@ export const version: string = '0.0.34', releaseDate: string = '2026-01-28', -releaseHash: string = 'e934822', +releaseHash: string = '95ba21a', licenseText: string = ` Copyright (c) 2024, Caltech From ac9dee8f8c4dc44509711ebeaf01431eb14fec01 Mon Sep 17 00:00:00 2001 From: "R. S. Doiel" Date: Wed, 28 Jan 2026 16:36:51 -0800 Subject: [PATCH 2/3] fixes #91, #82, needs testing --- codemeta.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/codemeta.json b/codemeta.json index 35597c0..25973c4 100644 --- a/codemeta.json +++ b/codemeta.json @@ -98,9 +98,9 @@ "GNU Make", "Pandoc 3.1" ], - "version": "0.0.34", + "version": "0.0.35", "developmentStatus": "wip", "issueTracker": "https://github.com/caltechlibrary/cold/issues", "downloadUrl": "https://github.com/caltechlibrary/cold/release/latest", - "releaseNotes": "- Implemented changes in issue #91\n- Minor UI view edits from release v0.0.34" + "releaseNotes": "- Implemented changes in issue #91 and issue #82\n- Minor UI view edits from release v0.0.34" } \ No newline at end of file From 330d2d14f7202f16e18c4dbc18f2f0d1f375bc7e Mon Sep 17 00:00:00 2001 From: "R. S. Doiel" Date: Wed, 28 Jan 2026 17:14:19 -0800 Subject: [PATCH 3/3] fix issue 91 and 82 --- CITATION.cff | 2 +- about.md | 7 ++++--- cold.1.md | 2 +- cold_reports.1.md | 2 +- directory_api.ts | 3 +++ directory_client.ts | 5 ++++- directory_sync.1.md | 2 +- division_people.1.md | 2 +- group_vocabulary.1.md | 2 +- htdocs/about.html | 5 +++-- htdocs/about.md | 7 ++++--- htdocs/modules/directory_client.js | 5 ++++- installer.ps1 | 2 +- installer.sh | 2 +- journal_vocabulary.1.md | 2 +- people.ts | 3 ++- people_vocabulary.1.md | 2 +- thesis_option_vocabulary.1.md | 2 +- version.ts | 4 ++-- 19 files changed, 37 insertions(+), 24 deletions(-) diff --git a/CITATION.cff b/CITATION.cff index 2536a98..8fcd3fa 100644 --- a/CITATION.cff +++ b/CITATION.cff @@ -29,7 +29,7 @@ contacts: email: rsdoiel@caltech.edu repository-code: "https://github.com/caltechlibrary/cold" -version: 0.0.34 +version: 0.0.35 date-released: 2026-01-28 license-url: "https://caltechlibrary.github.io/cold/LICENSE" diff --git a/about.md b/about.md index 19eb25c..1bf3ed6 100644 --- a/about.md +++ b/about.md @@ -32,7 +32,7 @@ maintainer: id: https://orcid.org/0000-0003-0900-6903 repository_code: https://github.com/caltechlibrary/cold -version: 0.0.34 +version: 0.0.35 license_url: https://caltechlibrary.github.io/cold/LICENSE operating_system: - Linux @@ -58,9 +58,10 @@ date_released: 2026-01-28 About this software =================== -## cold 0.0.34 +## cold 0.0.35 -- Implemented changes in issue #90, restricted dataset version to 2.2.0 due to bug in people_names query processing. +- Implemented changes in issue #91 and issue #82 +- Minor UI view edits from release v0.0.34 ### Authors diff --git a/cold.1.md b/cold.1.md index bd84584..8e39e1b 100644 --- a/cold.1.md +++ b/cold.1.md @@ -1,4 +1,4 @@ -%cold(1) user manual | 0.0.34 95ba21a +%cold(1) user manual | 0.0.35 ac9dee8 % R. S.Doiel % 2026-01-28 diff --git a/cold_reports.1.md b/cold_reports.1.md index c2a1dbf..3dc7511 100644 --- a/cold_reports.1.md +++ b/cold_reports.1.md @@ -1,4 +1,4 @@ -%cold_reports(1) user manual | 0.0.34 95ba21a +%cold_reports(1) user manual | 0.0.35 ac9dee8 % R. S.Doiel % 2026-01-28 diff --git a/directory_api.ts b/directory_api.ts index 016eb1b..90cabc9 100644 --- a/directory_api.ts +++ b/directory_api.ts @@ -56,6 +56,9 @@ export async function directoryLookup( record.bio = getElementValue(document, ".bio"); record.office = getElementValue(document, ".office"); record.email = getElementValue(document, ".email"); + if (record.email.trim() === "[email protected]") { + record.email = ""; + } return record; } if (resp.body !== null) { diff --git a/directory_client.ts b/directory_client.ts index 0e869af..4fee2e9 100644 --- a/directory_client.ts +++ b/directory_client.ts @@ -34,10 +34,13 @@ function updateRecord(obj: object) { } if ( obj.email !== undefined && obj.email !== "" && - obj.email != "[email protected]" + obj.email.indexOf("[email protected]") >= 0 ) { email_elem.value = obj.email; } + if (email_elem.value.indexOf("[email protected]") >= 0) { + email_elem.value = ""; + } if (obj.division !== undefined && obj.division !== "") { if (division_elem.value === "") { division_elem.value = obj.division; diff --git a/directory_sync.1.md b/directory_sync.1.md index e20b9f9..cdddf53 100644 --- a/directory_sync.1.md +++ b/directory_sync.1.md @@ -1,4 +1,4 @@ -%directory_sync(1) user manual | 0.0.34 95ba21a +%directory_sync(1) user manual | 0.0.35 ac9dee8 % R. S.Doiel % 2026-01-28 diff --git a/division_people.1.md b/division_people.1.md index c7999db..a36cef7 100644 --- a/division_people.1.md +++ b/division_people.1.md @@ -1,4 +1,4 @@ -%division_people(1) user manual | 0.0.34 95ba21a +%division_people(1) user manual | 0.0.35 ac9dee8 % R. S.Doiel % 2026-01-28 diff --git a/group_vocabulary.1.md b/group_vocabulary.1.md index ea662ba..96e4e68 100644 --- a/group_vocabulary.1.md +++ b/group_vocabulary.1.md @@ -1,4 +1,4 @@ -%group_vocabulary(1) user manual | 0.0.34 95ba21a +%group_vocabulary(1) user manual | 0.0.35 ac9dee8 % R. S.Doiel % 2026-01-28 diff --git a/htdocs/about.html b/htdocs/about.html index 7efdff8..e284d83 100644 --- a/htdocs/about.html +++ b/htdocs/about.html @@ -22,9 +22,10 @@

About this software

-

cold 0.0.34

+

cold 0.0.35

    -
  • Implemented changes in issue #90, restricted dataset version to 2.2.0 due to bug in people_names query processing.
  • +
  • Implemented changes in issue #91 and issue #82
  • +
  • Minor UI view edits from release v0.0.34

Authors

    diff --git a/htdocs/about.md b/htdocs/about.md index 19eb25c..1bf3ed6 100644 --- a/htdocs/about.md +++ b/htdocs/about.md @@ -32,7 +32,7 @@ maintainer: id: https://orcid.org/0000-0003-0900-6903 repository_code: https://github.com/caltechlibrary/cold -version: 0.0.34 +version: 0.0.35 license_url: https://caltechlibrary.github.io/cold/LICENSE operating_system: - Linux @@ -58,9 +58,10 @@ date_released: 2026-01-28 About this software =================== -## cold 0.0.34 +## cold 0.0.35 -- Implemented changes in issue #90, restricted dataset version to 2.2.0 due to bug in people_names query processing. +- Implemented changes in issue #91 and issue #82 +- Minor UI view edits from release v0.0.34 ### Authors diff --git a/htdocs/modules/directory_client.js b/htdocs/modules/directory_client.js index 0a06662..6785242 100644 --- a/htdocs/modules/directory_client.js +++ b/htdocs/modules/directory_client.js @@ -17,9 +17,12 @@ function updateRecord(obj) { if (obj.given_name !== undefined && obj.given_name !== "") { lived_name_elem.value = obj.given_name; } - if (obj.email !== undefined && obj.email !== "" && obj.email != "[email protected]") { + if (obj.email !== undefined && obj.email !== "" && obj.email.indexOf("[email protected]") >= 0) { email_elem.value = obj.email; } + if (email_elem.value.indexOf("[email protected]") >= 0) { + email_elem.value = ""; + } if (obj.division !== undefined && obj.division !== "") { if (division_elem.value === "") { division_elem.value = obj.division; diff --git a/installer.ps1 b/installer.ps1 index abf6c34..00adca3 100755 --- a/installer.ps1 +++ b/installer.ps1 @@ -5,7 +5,7 @@ # Set the package name and version to install # $PACKAGE = "cold" -$VERSION = "0.0.34" +$VERSION = "0.0.35" $GIT_GROUP = "caltechlibrary" $RELEASE = "https://github.com/${GIT_GROUP}/${PACKAGE}/releases/tag/v${VERSION}" $SYSTEM_TYPE = Get-ComputerInfo -Property CsSystemType diff --git a/installer.sh b/installer.sh index 64d8cdc..e60d5a5 100755 --- a/installer.sh +++ b/installer.sh @@ -4,7 +4,7 @@ # Set the package name and version to install # PACKAGE="cold" -VERSION="0.0.34" +VERSION="0.0.35" GIT_GROUP="caltechlibrary" RELEASE="https://github.com/$GIT_GROUP/$PACKAGE/releases/tag/v$VERSION" diff --git a/journal_vocabulary.1.md b/journal_vocabulary.1.md index cd3d1e3..132d72c 100644 --- a/journal_vocabulary.1.md +++ b/journal_vocabulary.1.md @@ -1,4 +1,4 @@ -%journal_vocabulary(1) user manual | 0.0.34 95ba21a +%journal_vocabulary(1) user manual | 0.0.35 ac9dee8 % R. S.Doiel % 2026-01-28 diff --git a/people.ts b/people.ts index 5e7683e..afbfa13 100644 --- a/people.ts +++ b/people.ts @@ -266,7 +266,8 @@ export class People implements PeopleInterface { (obj.given_name === undefined || obj.given_name === "") ? this.given_name = "" : this.given_name = obj.given_name as unknown as string; - (obj.email === undefined || obj.email === "" || obj.email === "[email protected]") + (obj.email === undefined || obj.email === "" || + obj.email === "[email protected]") ? this.email = "" : this.email = obj.email as unknown as string; (obj.archivesspace_id === undefined || obj.archivesspace_id === "") diff --git a/people_vocabulary.1.md b/people_vocabulary.1.md index 5dec85c..0b5c305 100644 --- a/people_vocabulary.1.md +++ b/people_vocabulary.1.md @@ -1,4 +1,4 @@ -%people_vocabulary(1) user manual | 0.0.34 95ba21a +%people_vocabulary(1) user manual | 0.0.35 ac9dee8 % R. S.Doiel % 2026-01-28 diff --git a/thesis_option_vocabulary.1.md b/thesis_option_vocabulary.1.md index 4e81101..794fd93 100644 --- a/thesis_option_vocabulary.1.md +++ b/thesis_option_vocabulary.1.md @@ -1,4 +1,4 @@ -%thesis_option_vocabulary(1) user manual | 0.0.34 95ba21a +%thesis_option_vocabulary(1) user manual | 0.0.35 ac9dee8 % R. S.Doiel % 2026-01-28 diff --git a/version.ts b/version.ts index fb17332..3c4e7c8 100644 --- a/version.ts +++ b/version.ts @@ -1,8 +1,8 @@ // cold version and license information. -export const version: string = '0.0.34', +export const version: string = '0.0.35', releaseDate: string = '2026-01-28', -releaseHash: string = '95ba21a', +releaseHash: string = 'ac9dee8', licenseText: string = ` Copyright (c) 2024, Caltech