From d9e737932adc02b52d9c88da072daca120ef3350 Mon Sep 17 00:00:00 2001 From: Silas Strawn Date: Wed, 1 Jun 2022 14:38:44 -0700 Subject: [PATCH 1/2] Fix https://github.com/microsoft/azure-container-apps/issues/234 --- src/containerapp/azext_containerapp/custom.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/containerapp/azext_containerapp/custom.py b/src/containerapp/azext_containerapp/custom.py index 86aaebba9f5..9f638f3238a 100644 --- a/src/containerapp/azext_containerapp/custom.py +++ b/src/containerapp/azext_containerapp/custom.py @@ -2344,7 +2344,10 @@ def containerapp_up_logic(cmd, resource_group_name, name, managed_env, image, en ingress_def = None if target_port is not None and ingress is not None: - ingress_def = IngressModel + if ca_exists: + ingress_def = containerapp_def["properties"]["configuration"]["ingress"] + else: + ingress_def = IngressModel ingress_def["external"] = external_ingress ingress_def["targetPort"] = target_port containerapp_def["properties"]["configuration"]["ingress"] = ingress_def From b1404ba5693c46cc46e04188b2c68e59cae5aa0b Mon Sep 17 00:00:00 2001 From: Haroon Feisal Date: Fri, 3 Jun 2022 15:18:44 -0400 Subject: [PATCH 2/2] Added history note. --- src/containerapp/HISTORY.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/containerapp/HISTORY.rst b/src/containerapp/HISTORY.rst index 99aba7e9a08..5cf8ecafcb8 100644 --- a/src/containerapp/HISTORY.rst +++ b/src/containerapp/HISTORY.rst @@ -8,7 +8,7 @@ Release History * Added parameter --environment to 'az containerapp list' * Added 'az containerapp revision label swap' to swap traffic labels * BREAKING CHANGE: 'az containerapp revision list' now shows only active revisions by default, added flag --all to show all revisions - +* Fixed but with 'az containerapp up' where custom domains would be removed when updating existing containerapp 0.3.5 ++++++