Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cider DAP Metadata Table Generation #2197

Merged
merged 9 commits into from
Jul 15, 2024
Merged

Cider DAP Metadata Table Generation #2197

merged 9 commits into from
Jul 15, 2024

Conversation

smd21
Copy link
Contributor

@smd21 smd21 commented Jul 5, 2024

Addresses issue #2183
This branch implements a new compiler pass to generate the metadata table for calyx-to-calyx debugging.

EclecticGriffin
EclecticGriffin requested changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@EclecticGriffin EclecticGriffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! Left a few notes here and there. You should also add a runt test for the pass in the passes section of the test suite

calyx-utils/src/position.rs Outdated Show resolved Hide resolved
calyx-opt/src/passes/metadata_table_gen.rs Outdated Show resolved Hide resolved
calyx-opt/src/passes/metadata_table_gen.rs Outdated Show resolved Hide resolved
calyx-opt/src/passes/metadata_table_gen.rs Outdated Show resolved Hide resolved
calyx-opt/src/passes/metadata_table_gen.rs Outdated Show resolved Hide resolved
calyx-opt/src/passes/metadata_table_gen.rs Outdated Show resolved Hide resolved
calyx-opt/src/passes/metadata_table_gen.rs Outdated Show resolved Hide resolved
calyx-opt/src/passes/metadata_table_gen.rs Outdated Show resolved Hide resolved
calyx-opt/src/passes/metadata_table_gen.rs Outdated Show resolved Hide resolved
calyx-opt/src/passes/metadata_table_gen.rs Show resolved Hide resolved
EclecticGriffin
EclecticGriffin requested changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@EclecticGriffin EclecticGriffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! Left a few notes here and there. You should also add a runt test for the pass in the passes section of the test suite

@smd21 smd21 enabled auto-merge (squash) July 15, 2024 18:20
@smd21 smd21 merged commit 907bcd1 into main Jul 15, 2024
18 checks passed
@smd21 smd21 deleted the cider-dap-metadata-table branch July 15, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EclecticGriffin EclecticGriffin EclecticGriffin requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smd21 @EclecticGriffin