New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YouTube does not respect quality preference #726

Closed
Bittenspoder opened this Issue Dec 15, 2017 · 8 comments

Comments

Projects
None yet
3 participants
@Bittenspoder

Bittenspoder commented Dec 15, 2017

Please fill out the templates below to the best of your ability, based on whether your problem is with using the website or with running your own server.

Website Problem

Please confirm whether you've tried the following debugging steps:

  • Clearing cache and refreshing the page (On Firefox, press Ctrl+F5. On Chrome, press F12, then right click the refresh button and click "Empty Cache and Hard Reload")
  • [*] Disabling all browser extensions
  • [*] Using a clean channel with no customizations

Description of the Problem

  • What triggers the problem? inaction of switching 240-1080/highest setting for youtube in NavBar -> OPTIONS -> Playback Tab -> Quality Preference
  • What happens? video refreshes quality unchanged
  • What do you expect to happen instead? quality of video to change when refreshed

System Information

On Firefox, press Ctrl+Shift+K to open the JavaScript console. On Chrome, press Ctrl+Shift+J.

@calzoneman

This comment has been minimized.

Owner

calzoneman commented Dec 15, 2017

Hi,

I tested with my example 1080p drive video and confirmed that both the gear icon on the video player itself and the Options->Playback quality preference are working as expected in Firefox and Chromium.

1. Can you provide an example link to a video that you're having a problem with? Some videos, especially if you just uploaded them, may not have all qualities generated by Google Drive yet.
2. Your console screenshot shows some additional output which indicates that a custom script is running on the channel. Please try disabling all custom scripts from the Options menu and see if you're still having the issue, in case your channel JS might be patching the player.

Issue appears to be related to YouTube, not Drive.

@calzoneman

This comment has been minimized.

Owner

calzoneman commented Dec 15, 2017

Actually can you clarify something? The title of the issue confuses me, are you saying it works with YouTube and doesn't work for drive, or that it works for drive and doesn't work for YouTube?

@calzoneman

This comment has been minimized.

Owner

calzoneman commented Dec 15, 2017

I went ahead and checked YouTube and it does appear to be a regression. The YouTube player API setPlaybackQuality() does absolutely nothing.

I see a few references to this on the issue tracker, such as 1 and 2, which have deleted comments but appear to suggest that something changed in YouTube's API about the way these are handled. In particular, it may no longer be possible to change the quality once the video has started playing, which is kind of stupid in my opinion, but since CyTube only explicitly sets the quality at the beginning it may be possible to work around this.

@calzoneman

This comment has been minimized.

Owner

calzoneman commented Dec 15, 2017

Those above tickets are pretty stale, but there was a new one created December 9 and not commented yet: https://issuetracker.google.com/issues/70440398

From what I can tell, the setPlaybackQuality API doesn't work at all at the moment which means there's no way to control the quality preference of the YouTube player.

@calzoneman

This comment has been minimized.

Owner

calzoneman commented Dec 15, 2017

I could not figure out how to add a comment to that bug report, so I filed a new bug report with YouTube: https://issuetracker.google.com/issues/70699731

Hopefully they reply to that and fix it, but if not, I'm afraid there's not anything else I can do here.

@calzoneman calzoneman changed the title from Quality Preference Selector for Youtube -works with Gdrive to YouTube does not respect quality preference Dec 15, 2017

@Xaekai

This comment has been minimized.

Collaborator

Xaekai commented Dec 16, 2017

We meet once again Google's fault label. heh

@calzoneman

This comment has been minimized.

Owner

calzoneman commented Feb 28, 2018

It appears Google does not intend to support this anymore:

Status: Won't Fix (Intended Behavior)
An update -- due to changes in our player infrastructure, the player will no longer honor requests to set a manual playback quality via the API. As documented, the player has always made a "best effort" to respect the requested quality.

The documentation will be updated in the future to indicate this call is no longer supported, though it will still be available as a "no-op" for compatibility purposes.

So I guess the only thing left to do here is update CyTube to add a disclaimer that quality selection is unsupported for YouTube.

@calzoneman

This comment has been minimized.

Owner

calzoneman commented Mar 6, 2018

Closing this out via the above commit. Will be in the next live update.

@calzoneman calzoneman closed this Mar 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment