Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added README.md, added 2 exclamation marks, removed semicolons #4

Merged
merged 4 commits into from Apr 20, 2019
Merged

Added README.md, added 2 exclamation marks, removed semicolons #4

merged 4 commits into from Apr 20, 2019

Conversation

temeje
Copy link
Contributor

@temeje temeje commented Apr 20, 2019

  • Added a Readme.
  • Added 2 exclamation marks because I thought a bit more emphasis was necessary.
  • Removed semicolons, because Prettier decided to do that

keywordnew
keywordnew approved these changes Apr 20, 2019
View reviewed changes
Copy link
Member

@keywordnew keywordnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

daffl
daffl suggested changes Apr 20, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
preetdeol
preetdeol reviewed Apr 20, 2019
View reviewed changes
Copy link

@preetdeol preetdeol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi

atifali
atifali reviewed Apr 20, 2019
View reviewed changes
Copy link
Contributor

@atifali atifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe include 'npm install' step before npm start?

@keywordnew @temeje
Update README.md as suggested
a46f44a 
Co-Authored-By: temeje <temmje@gmail.com>
@keywordnew
Copy link
Member

I think all the comments are resolved. Merging!

@keywordnew keywordnew merged commit 284a07c into cambiecollective:master Apr 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keywordnew keywordnew keywordnew approved these changes

@atifali atifali atifali left review comments

@preetdeol preetdeol preetdeol left review comments

@daffl daffl daffl requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@temeje @keywordnew @daffl @atifali @preetdeol