Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend functionality of User Admin screen #116

Closed
philosophicles opened this issue Mar 3, 2014 · 11 comments
Closed

Extend functionality of User Admin screen #116

philosophicles opened this issue Mar 3, 2014 · 11 comments
Assignees
Milestone

Comments

@philosophicles
Copy link
Member

@philosophicles philosophicles commented Mar 3, 2014

The user admin screen http://beta.camdram.net/admin/users is missing a few useful features. (We can fallback to V1 for these for now; writing down for the longer-term.)

  • Issue a password reset
  • See the UserID in the table-list of users (handy for more complex support issues)
  • Sort the list

The roles also don't appear to be displaying entirely correctly/consistently for each user. E.g. http://beta.camdram.net/admin/users/1 does not have ROLE_SUPER_ADMIN while /445 (me) does; we both have the necessary magic flag within v1. I'm not sure if this is an issue, undeveloped feature, or something else.

@hoyes hoyes added this to the Laurie milestone Mar 6, 2014
@ajf58

This comment has been minimized.

Copy link
Contributor

@ajf58 ajf58 commented Jul 9, 2014

Password resets can always be done by users themselves and this is true for v1 and v2. I've never worked out why this feature is useful as a result.

@philosophicles

This comment has been minimized.

Copy link
Member Author

@philosophicles philosophicles commented Jul 10, 2014

I have definitely encountered users for whom it would be far, far slower to walk them through a password reset, than just doing it myself. I've used the reset feature a number of times on v1.

This is probably something I could have a go at if you guys would rather spend time on bigger things. That said, it won't be right up on my list, but if I'm the only person wanting it, that's probably ok :-)

@philosophicles

This comment has been minimized.

Copy link
Member Author

@philosophicles philosophicles commented Dec 3, 2014

The user search functionality on this page is also not working full as I'd expect. When I start typing in a name, I get the auto-complete drop-down and if I click on an entry from that, I'm taken to that user's page as expected.

However, after typing in a few characters in the search box e.g. 'Stu' or 'Stuart', if I press enter - the table of users is now empty. I'd expect all matching users LIKE '%Stu%' to be shown in the table. This is the case whether auto-complete had filled in a best-guess match or not.

This makes it a bit harder to impersonate a specific user, if they are somewhere in the middle of the table of all users.

hoyes added a commit that referenced this issue Dec 8, 2014
…d moved several options there. Implemented password reset option and added user IDs to views #116
@hoyes

This comment has been minimized.

Copy link
Member

@hoyes hoyes commented Dec 8, 2014

The above implements:

  • Password reset
  • user IDs
    It also moves a lot of the options in the table to the individual user page, which may remove some of the need for table browsing.

Still to do:

  • Sorting table
  • Fix user searching
@philosophicles

This comment has been minimized.

Copy link
Member Author

@philosophicles philosophicles commented Jan 10, 2015

It would also be helpful if the user search matched against email address, e.g. entering a CRSid would find the person.

@philosophicles

This comment has been minimized.

Copy link
Member Author

@philosophicles philosophicles commented Feb 22, 2015

Related to user search behaviour - the autocomplete drop-down seems to apply a DISTINCT filter. E.g. if there are two users with the same name, only one entry in the drop-down list is shown (which consistently takes me to the record with lower/older user id I think). Both entries should be shown.

@philosophicles

This comment has been minimized.

Copy link
Member Author

@philosophicles philosophicles commented Jul 3, 2015

@hoyes I've just re-remembered this and would say that the user search features commented above do need to be part of Laurie. (This issue is in Laurie so AOK, but your recent webteam email didn't list this one - hence just giving it a nudge.)

@hoyes

This comment has been minimized.

Copy link
Member

@hoyes hoyes commented Jul 3, 2015

Understood and noted!

@philosophicles

This comment has been minimized.

Copy link
Member Author

@philosophicles philosophicles commented Feb 2, 2016

Another element of this functionality is the ability to edit users' roles/privileges, e.g. give a user ROLE_SUPER_ADMIN or revoke it.

This currently still has to be done via V1 so, whilst really rare, is ideally necessary before decommissioning V1. (Worst case we could do it in SQL directly, it is that rare...)

@CHTJonas

This comment has been minimized.

Copy link
Member

@CHTJonas CHTJonas commented Jul 5, 2018

Just giving this a bump as it may be relevant given your recent work with Elasticsearch @hoyes

@CHTJonas

This comment has been minimized.

Copy link
Member

@CHTJonas CHTJonas commented Jul 25, 2018

The ability to give/revoke ROLE_SUPER_ADMIN privileges to a user I think is the broad intention of #399. There seems to be a suggestion floating somewhere that this shouldn't be done via the Camdram UI, but via a console command such as eg. #394.

From the original issue we have:

  • Password reset
  • User IDs
  • Edit privileges
  • Table sorting
  • Fix searching
@GKFX GKFX self-assigned this Aug 30, 2018
@GKFX GKFX closed this in 1a4307a Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.