New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vacancy times one hour too late. #563

Closed
CHTJonas opened this Issue Dec 20, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@CHTJonas
Copy link
Member

CHTJonas commented Dec 20, 2018

Vacancy expiry times shown in the frontend are mis-aligned by one hour. Likely introduced by #543 which we thought would only be an issue during BST and so could patch before April - turns out it's an issue right now too 馃槩 .

Example:
https://www.camdram.net/shows/2019-legally-blonde/techie-advert/edit shows vacancy expires at 16:00.
https://www.camdram.net/vacancies/techies shows the same vacancy expires at 17:00.

Interestingly the API https://www.camdram.net/vacancies/techies.json shows the correct expiry time.

Support ticket: https://support.camdram.net/tickets/1304

@hoyes

This comment has been minimized.

Copy link
Member

hoyes commented Dec 20, 2018

This is quite a cool bug:

  • The deadline time for techie adverts (and applications) is stored in a separate field to the date.
  • PHP doesn't have a time-only data type, so it gets deserialized as a DateTime object with the date fields set to the Unix epoch (1st Jan 1970)
  • Changes in #543 now mean that {{ deadlineTime | date("H:i") }} implicitly causes the "time" to be converted to the "Europe/London" timezone
  • It just so happens that from 1968 to 1971 the UK experimented with sticking in UTC+1 all year around (https://en.wikipedia.org/wiki/British_Summer_Time), so times on the 1st January 1970 get converted to "BST"...
@GKFX

This comment has been minimized.

Copy link
Contributor

GKFX commented Dec 20, 2018

Wow. I guess you learn something every day!

hoyes added a commit that referenced this issue Dec 20, 2018

@hoyes hoyes closed this Dec 20, 2018

@hoyes hoyes self-assigned this Dec 21, 2018

@philosophicles

This comment has been minimized.

Copy link
Contributor

philosophicles commented Dec 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment