New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some links in emails are relative and therefore don’t work #565

Closed
GKFX opened this Issue Dec 21, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@GKFX
Copy link
Contributor

GKFX commented Dec 21, 2018

Apparently there’s a absolute_url() Twig function (or there was in Symfony 2.7) – just need to see if that works.

@GKFX GKFX added the bug label Dec 21, 2018

@hoyes

This comment has been minimized.

Copy link
Member

hoyes commented Jan 13, 2019

Do you have an example of this? All the URLs in app/Resources/views/email seem to be using url()

@GKFX

This comment has been minimized.

Copy link
Contributor

GKFX commented Jan 13, 2019

The issue is in this section:

<h4><a href=3D"/shows/2019-the-mandrake-mandragola">The Mandrake - Mandrago=
la</a>
    </h4>
<p>    <meta itemprop=3D"startDate" content=3D"2019-02-14">
    <span itemprop=3D"location" itemscope=3D"" itemtype=3D"http://schema.or=
g/PerformingArtsTheater">
        <meta itemprop=3D"name" content=3D"Judith E. Wilson Drama Studio"><=
meta itemprop=3D"address" content=3D"United Kingdom">
    </span>
    19:30, Thu 14th February 2019 - Thu 14th February 0002            at <a=
 href=3D"/venues/judith-e-wilson-drama-studio">Judith E. Wilson Drama Studi=
o</a>                <br>

full sample email.

Emails have now started to look like this in MS Outlook online, with something markdown-like:
image

but I am unable to reproduce that appearance with the same email in another client:
image

My wild guess is that Outlook's way of sanitising relative links in emails it to display them in pseudo-markdown, it seems improbable that we would be sending those square brackets.

@GKFX

This comment has been minimized.

Copy link
Contributor

GKFX commented Jan 13, 2019

(Also the links should all be HTTPS not HTTP.)

@CHTJonas

This comment has been minimized.

Copy link
Member

CHTJonas commented Jan 14, 2019

How weird... Could perhaps try diffing the emails by source in one client vs. another? Shouldn't be any different and I doubt they will but sounds like there's some monkey business going on here somewhere 🙈

@CHTJonas CHTJonas added the design label Jan 14, 2019

@GKFX GKFX closed this in 8268b3f Jan 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment