Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Mailgun #605

Open
philosophicles opened this Issue Mar 3, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@philosophicles
Copy link
Member

philosophicles commented Mar 3, 2019

Set up a free, no-card-details Mailgun account to test integration and evaluate.

Move to replace Postal if it all works nicely. (Which it probably will.)

As part of this, review all email-triggering parts of the codebase to ensure there are no foreseeable mechanisms by which vast slews (10k order of magnitude or more) of repeat emails could unwittingly/unintentionally be sent in fairly short periods of time (24-48 hours). Because this would become somewhat expensive, and the recipients wouldn't like it.

I say 24-48 hours in case admins are all away-from-computer for a weekend, for example. Over longer time periods, we would be able to intervene first. 10k sends in 48 hours = 3-4 emails per minute consistently.

@CHTJonas gave one possible example of editing unauthorised shows regenerating a 'needs approval' email. Could that be abused, for example? What about the ability to send emails to society / venue admins? That kind of thing. I think this is quite unlikely but better considered up front!

Completing this would invalidate #603.

@GKFX

This comment has been minimized.

Copy link
Member

GKFX commented Mar 12, 2019

#548 (message queuing/sending of one email for many events) would address most of the concerns raised here about an excessive email volume. If we're sending at most one email per person per hour (or something like that) then that puts a very reasonable upper bound on our outgoing emails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.