Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server-side non-null check required for all date/time fields #612

Open
GKFX opened this Issue Mar 13, 2019 · 1 comment

Comments

Projects
None yet
1 participant
@GKFX
Copy link
Member

GKFX commented Mar 13, 2019

Safari for desktop still does not support native input[type=date], and so does not enforce the required attribute. This causes an HTTP 500 to be returned to the user if they forget any fields.
Not (as previously thought) related to #604.

E.g.: https://sentry.io/organizations/camdram-webteam/issues/856807794/?project=1273126&referrer=github_plugin

ErrorException: Uncaught Symfony\Component\Debug\Exception\FatalThrowableError: Call to a member function setTimezone() on null in /var/www/camdram/production/releases/32/src/Acts/CamdramBundle/Form/Type/AuditionType.php:40
Stack trace:
#0 /var/www/camdram/production/releases/32/vendor/symfony/symfony/src/Symfony/Component/EventDispatcher/EventDispatcher.php(212): Acts\CamdramBundle\Form\Type\AuditionType->Acts\CamdramBundle\Form\Type\{closure}(Object(Symfony\Component\Form\FormEvent), 'form.bind', Object(Symfony\Component\EventDispatcher\EventDispatcher))
#1 /var/www/camdram/production/releases/32/vendor/symfony/symfony/src/Symfony/Component/EventDispatcher/EventDispatcher.php(44): Symfony\Component\EventDispatcher\EventDispatcher->doDispatch(Array, 'form.bind', Object(Symfony\Component\Form\FormEvent))
#2 /var/www/camdram/production/releases/32/vendor/symfony/symfony/src/Symfony/Component/EventDispatcher/ImmutableEventDispatcher.php(33): Symfony\Component\EventDispatcher\EventDispatcher->dispatch('form.bind', Object(Symfon
  File "src/Acts/CamdramBundle/Form/Type/AuditionType.php", line 40, in handleFatalError
    $endAtTime->setTimezone(new \DateTimezone('Europe/London'));

@GKFX GKFX added the bug label Mar 13, 2019

@GKFX

This comment has been minimized.

Copy link
Member Author

GKFX commented Mar 13, 2019

See also Sentry issue: CAMDRAM-WEB-8Q

@GKFX GKFX changed the title Start/end date confusion still present in auditions Server-side non-null check required for all date/time fields Mar 16, 2019

GKFX added a commit that referenced this issue Mar 16, 2019

Handle blank date/time in auditions. Fix CAMDRAM-WEB-8Q Fix CAMDRAM-W…
…EB-8R

Part of #612. Two tests are broken by this change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.