Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
OAuth2 scopes bug #622
Something is wrong with external OAuth login for certain user(s). Unfortunately the error messages aren't very forgiving...
It also seems to work fine for me, but not for the user in question below (won't mention their name here for data protection but see Sentry). I'll try and ask a few other people to test this but to help diagnose it might help if people could try navigating to https://roombooking-dev.adctheatre.com and logging in to see if you experience the same issue?
Sentry issue: CAMDRAM-WEB-8B
Seems to be line 1115 of
throw new OAuth2ServerException(Response::HTTP_BAD_REQUEST, self::ERROR_INVALID_REQUEST, "No client id supplied");
But the POST'ed request body clearly shows the
After a few hours of messing around, I believe I have narrowed down the problem. The first time a user attempts to authenticate using Camdram to an external application using OAuth2, the "The app XXX would like to access your profile on Camdram" message appears on Camdram. At this point the "Allow" and "Cancel" buttons work as expected. However upon clicking said "Allow" button, the required scopes are not stored in the
When attempting to log in to the app in question again at a later date, the same screen appears again. Upon clicking either the "Allow" or "Cancel" buttons an exception is thrown. If I manually set the
This may be related to #402.