Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate email field in contact forms #661

Open
GKFX opened this issue May 19, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@GKFX
Copy link
Member

commented May 19, 2019

Supplying an invalid email address should generate a form validation error and get thrown back at the user, not throw a 500. Still this prevented a spam email reaching us, so there are some upsides!
See https://sentry.io/organizations/camdram-webteam/issues/1033154423/?referrer=github_plugin.

Swift_RfcComplianceException: Address in mailbox given [g.h.b.2.9.@cam.ac.uk] does not comply with RFC 2822, 3.6.2.
  File "src/Acts/CamdramBundle/Service/EmailDispatcher.php", line 102, in sendContactUsEmail
    ->setReplyTo($from)
  File "src/Acts/CamdramBundle/Controller/ContactUsController.php", line 32, in sendAction
    $emailDispatcher->sendContactUsEmail($data['email'], $data['subject'], $data['message']);
  File "web/app.php", line 28
    $response = $kernel->handle($request);
...
(14 additional frame(s) were not displayed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.