Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve layout of vacancy pages #670

Open
CHTJonas opened this issue May 30, 2019 · 4 comments

Comments

Projects
None yet
3 participants
@CHTJonas
Copy link
Member

commented May 30, 2019

I propose we add horizontal rule-offs to the list of blocked regexes in the Camdram Markdown parser. Personally I think it looks a bit odd when people do this since we're using <hr> tags to split up each applications. Easy change but wanted to poll for consensus before I make the change since it's a feature already being used.

Eg. https://www.camdram.net/vacancies/applications#gilbert-and-sullivan-society

@GKFX

This comment has been minimized.

Copy link
Member

commented May 31, 2019

<hr> tags can add meaning to a long post. Perhaps they could be made narrower in width (or something) to distinguish them from the lines between posts?

There are actually a number of CSS issues with markdown in adverts, it’s very much a feature that was rushed out as a reaction to the XSS vulnerability of the old system. Ideally over the summer we’ll be able to look at the set of markdown adverts we’ve seen so far and adjust the styles so they look nicer. (Lists are an area where the styles seem to break particularly.)

@philosophicles

This comment has been minimized.

Copy link
Member

commented Jun 1, 2019

I also think some kind of internal divider is a good idea, if visually distinct from between-ads.

Or, maybe we shouldn't be using <hr> at all between adverts, if we can do something different that keeps them distinct. (The bold, orange header text for the show name is already a pretty good visual clue.) Then <hr> can be only within-advert (but should probably still be narrower as well).

Maybe this issue should be broadened to cover general style review of the advert / vacancies pages?

@philosophicles

This comment has been minimized.

Copy link
Member

commented Jun 1, 2019

Just staring at this GitHub page in front of my eyes - maybe our adverts should each have some kind of border all around them? A little bit like a GH issue comment does.

@CHTJonas CHTJonas changed the title Block horizontal rule-offs when parsing Markdown Improve layout of vacancy pages Jun 5, 2019

@CHTJonas CHTJonas added frontend and removed discussion needed labels Jun 5, 2019

@CHTJonas

This comment has been minimized.

Copy link
Member Author

commented Jun 5, 2019

I think I'm tending to agree with @philosophicles here so I've broadened the scope of the ticket slightly to encompass general frontend changes as opposed to changes to the Markdown parser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.