Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make line endings consistent #688

Open
CHTJonas opened this issue Jun 22, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@CHTJonas
Copy link
Member

commented Jun 22, 2019

User input is sometimes stored/served using Windows-style (CRLF) and sometime using Unix-style (LF) line endings. We should pick one and stick with it, sanitising user input/DB fields as necessary.

For example, that address field of the ADC's venue page is served as Park Street,\r\nCambridge,\r\nCB5 8AS through the API but at one point was served as Park Street,\nCambridge,\nCB5 8AS.

Personally I'd favour Unix-style endings, given we're running Linux and most people consuming the API for an app will most probably also be running something Linux-flavoured too.

@philosophicles

This comment has been minimized.

Copy link
Member

commented Jun 22, 2019

Seems eminently sensible and I agree with you that Unix-style is probably the best convention here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.