Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address multiple issues in ExternalUser entity #699

Open
CHTJonas opened this issue Jul 3, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@CHTJonas
Copy link
Member

commented Jul 3, 2019

Not really a bug or enhancement, but the ExternalUser entity and associated table in the database needs a bit of TLC/refactoring. Some basic tasks that were discussed in Gitter on 2019-07-03:

  • Scan the acts_external_users table and fix all user_id fields where the email address matches a record in acts_users.
  • Delete all records in acts_external_users where user_id is NULL.
  • Make the acts_external_users.user_id field non-nullable.
  • Drop the acts_external_users.person_id field and remove the relationship in the PHP.
@GKFX

This comment has been minimized.

Copy link
Member

commented Jul 5, 2019

External user entities with null user_id are created when a user logs in with an external service but doesn't complete signup, explaining why they continue to be created. This is partly because the screen the user reaches has not been updated for use without a password, so the intended flow

user logs in with new external provider → user links this to their existing account → user is now logged in and has a permanent new login provider

is not possible. I'm thinking now that we should just delete these once they are ~48 hours old as by that point they are obsolete—if the user's tab is still open at that point and they attempt to continue, they should appreciate that the request has "timed out" in some way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.