Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in show authorisation mechanism #747

Closed
CHTJonas opened this issue Nov 7, 2019 · 4 comments
Labels

Comments

@CHTJonas
Copy link
Member

@CHTJonas CHTJonas commented Nov 7, 2019

There seems to be a strange bug in the mechanism used to approve shows. It appears to be possible to update the authorised field to 0 yet still send the approval email.

@philosophicles do you remember anything unusual when you authorised this show?

Support Ticket: 2208

Audit Log: Acts\CamdramBundle\Entity\Show 6992

@CHTJonas CHTJonas added the bug label Nov 7, 2019
@GKFX

This comment has been minimized.

Copy link
Member

@GKFX GKFX commented Nov 8, 2019

No bug - the show was edited by admin at 2019-11-07 06:21:23, which automatically approves it and sends the email, then de-authorised by same admin 30 seconds later using the expected method and URL POST /shows/2019-freshers-panto-sketch-show/unapprove. Of course this is a usability bug, that the show shouldn't automatically be approved when an admin edits it, but that should be a separate ticket.

@CHTJonas

This comment has been minimized.

Copy link
Member Author

@CHTJonas CHTJonas commented Nov 8, 2019

Oh interesting I didn't realise it automatically did that. Seems a bit strange that the audit log entry at 2019-11-07 06:21:23 shows societies_display_list being updated but not authorised but hey.

@philosophicles

This comment has been minimized.

Copy link
Member

@philosophicles philosophicles commented Nov 8, 2019

Sorry for confusion caused @CHTJonas and @GKFX !

@GKFX

This comment has been minimized.

Copy link
Member

@GKFX GKFX commented Nov 8, 2019

No worries! Not your fault anyway, there's nothing you could do to make it work any better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.