Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Diary refactor #530
@CHTJonas' diary RSS feed link wasn't really working so I've removed it. Is there a use case for a diary RSS feeds though?
Getting a bit pernickety, but I don't really like how start/end times are formatted at the moment:
Wondering about changing it everywhere to something like
, with "end_at" and "repeat_until" being optional. Means that for performances (which don't have an end time), "end_at" will be absent, and for auditions (which don't repeat) "repeat_until" will be absent. It also mirrors how iCal / RFC 5545 works.
referenced this pull request
Nov 30, 2018
Whoops my mistake didn't check to see if the RSS reader actually returned anything sensible! Yes all looks good to me.
To be honest I think iCal subscriptions are of much more use to people these days than RSS feeds. Only other thing I can think of is that it might be useful to implement some kind of plain text view of the diary for people to copy/paste into emails and alike but I think that may be going a bit OTT.
Nov 30, 2018
Just testing/comparing https://www.camdram.net/societies/cambridge-university-amateur-dramatic-club/diary/2018/christmas-vacation.json which doesn't seem to work in the same way as the main https://www.camdram.net/diary/2018/christmas-vacation.json endpoint. Is this intentional?