New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove everything to do with passwords #394 #557

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@hoyes
Copy link
Member

hoyes commented Dec 16, 2018

I reckon the time is right for this (see #394 (comment)). Deleting code is very satisfying!

I've tried to leave helpful comments wherever there was previously a login form. Feel free to commit wording tweaks etc.

@hoyes hoyes self-assigned this Dec 16, 2018

@hoyes hoyes requested review from philosophicles , GKFX and CHTJonas Dec 16, 2018

@CHTJonas

This comment has been minimized.

Copy link
Member

CHTJonas commented Dec 16, 2018

Looks good to me. Would ideally contact the users who will be affected/lose PW access bearing in mind it's just a handful.

@philosophicles

This comment has been minimized.

Copy link
Contributor

philosophicles commented Dec 17, 2018

I agree with @CHTJonas about contacting the (10 or 7?) users affected - but have no problem with going ahead with this in general.

@GKFX

GKFX approved these changes Dec 17, 2018

Copy link
Contributor

GKFX left a comment

Also happy – in the event that passwords become useful again it’ll all be in the commit history so no great risks that I see.

@hoyes

This comment has been minimized.

Copy link
Member

hoyes commented Dec 17, 2018

Going to open a support ticket to each of the 10 people referred to in #394 before merging this in.

Want to include a deadline though... will go for 12th Jan (just before term starts again) if no objections...

@CHTJonas

This comment has been minimized.

Copy link
Member

CHTJonas commented Jan 10, 2019

Are we still on track for this merge's deadline? Should probably do a notice on social media etc. DId we get any replies to those 10 support tickets?

@hoyes

This comment has been minimized.

Copy link
Member

hoyes commented Jan 13, 2019

I dropped the ball on this. I started sending e-mails before Christmas but only sent 2... Didn't receive any response to those two.

Tempted to make it 19th Jan now (next weekend) whatever happens, and I'll send the remaining e-mails to the others tomorrow or Tuesday.

@CHTJonas CHTJonas added the security label Jan 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment