New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split socs and venues. Remove show.venue, fixes #465 #564

Open
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
1 participant
@GKFX
Copy link
Contributor

GKFX commented Dec 20, 2018

It's possible that societies and venues could benefit from being split further in the PHP, but the database at least now makes more sense.

The main reason this is a PR and not being pushed to master is that the DB migration is quite destructive. There are a number of old show entries with a venue but no performances at all:

SELECT id, LEFT(title,15), timestamp, venue, venid FROM acts_shows WHERE
  NOT EXISTS (SELECT id FROM acts_performances WHERE acts_performances.sid = acts_shows.id)
  AND (venid IS NOT NULL OR NOT (venue = '' OR venue IS NULL));
id title timestamp venue venid
1600 Wyrd 2007-10-05 01:10:35 Picturehouse NULL
2200 The Winter's Ta 2009-06-18 02:21:22 Jesus Orchard and Chapel NULL
2206 Lady Windermere 2009-06-30 14:15:30 http://RecordedDrama.co.uk NULL
2244 Surrealist Film 2009-10-31 16:00:34 Filmed in various locations around Cambridge NULL
2290 Pembroke Player 2011-05-31 13:26:02 Japanese and UK Venues NULL
2384 Macbeth 2010-02-11 14:14:50 40
2391 When In Rome 2010-06-30 11:11:54 Edinburgh Festival NULL
2647 CONSEQUENCES 2011-03-04 21:04:14 www.cu-tv.co.uk NULL
2685 The Return of D 2011-03-05 15:53:33 40
2812 The Adventure C 2011-06-03 18:01:04 CB2 NULL
2833 Sweeney Todd 2011-06-16 11:57:33 42
2939 Footlights Inte 2011-10-30 23:30:34 ADC Theatre NULL
2953 Denim 2011-11-13 22:29:44 42
2966 The Enchanted A 2012-06-15 19:46:29 (film) NULL
3053 Take the Fast T 2013-09-06 21:42:45 f NULL
3061 Newnham Smoker 2012-01-07 11:10:32 48
3063 Newnham Smoker 2012-02-09 13:24:59 48
3069 Top Bike 2012-01-14 14:15:27 Corpus Christi College NULL
3096 Wolfson Howler 2012-01-28 19:31:16 Wolfson College Club Room NULL
3142 Lucy Cavendish 2012-02-28 10:15:31 Lucy Cavendish Bar NULL
3223 The Art of Now 2012-04-25 16:18:14 Homerton Small Studio NULL
3523 'The King of En 2013-01-21 19:44:42 Girton College Chapel NULL
3558 The Canterbury 2013-01-21 19:28:55 Old Hall, Girton College NULL
3563 A Short Film 2013-02-05 20:22:22 A film so various locations NULL
3669 The Marvellous 2013-03-15 13:29:08 King's College Fellow's Garden NULL
3705 The Acid Test 2013-03-28 11:27:49 Homerton College Auditorium 90
3735 Tamburlaine Par 2013-05-01 14:02:50 Sidney Sussex Tennis Court Garden NULL
3736 Pembroke May We 2013-05-04 10:41:05 45
3755 Pembroke Player 2013-05-15 17:40:16 45
3817 Doctor Faustus 2013-06-20 04:33:03 43
3931 Cinecam Flagshi 2013-11-10 15:06:54 Various set locations NULL
3998 Scrooge & Marle 2013-11-26 22:18:04 Waterloo East Theatre, London NULL
4001 Marlowe Showcas 2013-11-22 10:42:14 London Venue, TBC NULL
4002 The Prime of Mi 2013-11-22 15:32:46 48
4054 On Her Majesty' 2014-01-05 17:28:21 30
4101 Venice Preserv' 2014-01-23 12:44:53 TBD NULL
4103 The Marlowe Sho 2014-01-21 18:34:56 St John's College, Cambridge; TBC, London NULL
4104 The Marlowe Sho 2014-01-25 01:39:31 St John's College, Cambridge; TBC, London NULL
4121 Shadow (short f 2014-02-11 23:32:03 Shooting in central Cambridge NULL
4233 Rickshaw Theatr 2014-03-04 17:33:15 Tbc NULL
4253 Sell by Date 2014-03-09 18:13:47 30
4299 The Jew of Malt 0000-00-00 00:00:00 Corpus Christi College Gardens NULL
4308 Pick of the Fri 2014-04-17 18:58:16 TBC NULL
4429 CUMTS Bar Night 0000-00-00 00:00:00 68
4443 Romeo & Juliet 0000-00-00 00:00:00 C Venues NULL
4444 Cartoon (SHORT 2014-07-01 10:27:42 Various Locations in Edinburgh NULL
4530 Freshers' Plays 2014-10-02 16:21:56 29

There other, more complicated discrepancies where the venue of the show doesn't agree with any venue of the performances. So this is another DB cleanup job!

@GKFX GKFX force-pushed the venue-split branch from 360f17d to c91457b Dec 20, 2018

GKFX added some commits Jan 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment