Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Split socs and venues. Remove show.venue, fixes #465 #564
It's possible that societies and venues could benefit from being split further in the PHP, but the database at least now makes more sense.
The main reason this is a PR and not being pushed to master is that the DB migration is quite destructive. There are a number of old show entries with a venue but no performances at all:
SELECT id, LEFT(title,15), timestamp, venue, venid FROM acts_shows WHERE NOT EXISTS (SELECT id FROM acts_performances WHERE acts_performances.sid = acts_shows.id) AND (venid IS NOT NULL OR NOT (venue = '' OR venue IS NULL));
There other, more complicated discrepancies where the venue of the show doesn't agree with any venue of the performances. So this is another DB cleanup job!