New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add User Guidelines & update Privacy Policy #556 #594

Merged
merged 20 commits into from Feb 9, 2019

Conversation

Projects
None yet
4 participants
@philosophicles
Copy link
Member

philosophicles commented Feb 3, 2019

  • Brand new User Guidelines page, referenced from the footer on all pages; also linked when users log in or add a new show.
  • Also includes significant rework to Privacy Policy, mainly because of the new UGs but also some general stylistic changes, etc. Some changes came from the discussion on #556, some from #171 (this PR potentially ticks off quite a few angles from that issue), and some just seemed sensible to me (trying to keep a logical separation between these documents, improve legal robustness etc).

We all contributed to the draft UGs already, but please note they have evolved somewhat more in the process of creating an actual webpage. Please do review the wording again if you're at all invested in it!

I'm totally OK if the suggested changes to the Privacy Policy create some debate; I'm not trying to unilaterally/undemocratically overhaul them. We can take debate to Gitter (or back to a Google Doc) if people want to - I thought I'd try to skip that step purely in the interests of making more rapid progress.

The New Show page has also changed somewhat noticeably - beyond just linking to the UGs. I took the opportunity to attempt to improve placement and formatting of guidance text, putting it closest to where it is relevant on the page.

No hurry to merge this - whenever we get consensus. When we have merged, there are still some final tasks for #556 i.e. emailing all users.

@philosophicles philosophicles requested review from hoyes , GKFX , CHTJonas and ajf58 Feb 3, 2019

@philosophicles

This comment has been minimized.

Copy link
Member Author

philosophicles commented Feb 3, 2019

Reviews welcome if you want to - no obligation. Just trying to be democratic =)

@CHTJonas
Copy link
Member

CHTJonas left a comment

All looks good to me, pending clarification on changing a show's society 😃

Show resolved Hide resolved app/Resources/views/show/new.html.twig Outdated
@philosophicles

This comment has been minimized.

Copy link
Member Author

philosophicles commented Feb 5, 2019

Thanks for the review @CHTJonas. Have hopefully addressed your point about socs. I will merge this sometime next weekend unless anyone else objects, or feel free to merge sooner if doing a release for any other reason.

@CHTJonas

This comment has been minimized.

Copy link
Member

CHTJonas commented Feb 5, 2019

Might be worth an email to the Gossip List in addition to a userbase mailout maybe?

GKFX and others added some commits Feb 6, 2019

@philosophicles philosophicles merged commit bfc3c34 into master Feb 9, 2019

3 checks passed

buddy/pipeline/Development Deploy Build successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@philosophicles philosophicles deleted the userguidelines branch Feb 9, 2019

CHTJonas added a commit that referenced this pull request Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment