Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature person tabs #703

Merged
merged 5 commits into from Jul 14, 2019

Conversation

Projects
None yet
2 participants
@GKFX
Copy link
Member

commented Jul 9, 2019

A solution to overcrowded person pages. People whose roles can be split into multiple tabs have those tabs appear on their page. By default, roles are categorized into prod/band/crew, but users can override these choices by tagging each role with a string.

Fixes #660.

@GKFX GKFX force-pushed the feature-person-tabs branch from def85da to 68ad1d5 Jul 9, 2019

@CHTJonas

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

This is so great - thanks for this @GKFX!! Two requests, both about the API (you know me...):

  1. Currently the type field in each role exposed at the /people/:slug/roles.json endpoint ignores any custom tagging done in the frontend.
  2. Is it possible to expose the list of all tags at e.g. /people/:slug/role-tags.json or similar?
@GKFX

This comment has been minimized.

Copy link
Member Author

commented Jul 9, 2019

My preference would be to just add the tags to the existing roles.json endpoint as a new property where non-null and not create a new endpoint. Processing the JSON to determine the list of tags then requires only a map function and de-duplication on the returned array so there’s not much value in doing that server-side and providing a dedicated endpoint.

@GKFX GKFX force-pushed the feature-person-tabs branch from 68ad1d5 to 4c35424 Jul 9, 2019

GKFX added some commits Jul 8, 2019

@GKFX GKFX force-pushed the feature-person-tabs branch from 4c35424 to e4f4d99 Jul 14, 2019

@GKFX GKFX merged commit e4f4d99 into master Jul 14, 2019

0 of 2 checks passed

buddy/pipeline/Development Deploy Build in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@GKFX GKFX deleted the feature-person-tabs branch Jul 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.