Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Image View Mode Demo

commit 8e95f70c9c47168305970e91021072673d7cdad8 1 parent 8bf009f
@cameronmcefee authored
View
BIN  1_normal.jpg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
View
BIN  2_transparentPixels.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
View
BIN  3_tooLarge.jpg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
View
BIN  4_differentSize.jpg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

157 comments on commit 8e95f70

@rubiii

wow :)

@floere

Nice :)

@tvandervossen

Sexy. Would be nice if you could also just click and drag inside the image to change the Swipe and Onion Skin sliders. They’re a bit fiddly now.

@pjvds

Awesome!

@isaachall

I hear that in the next release will contain a slider to control how many of your bugs GitHub automatically corrects for you.

@SunboX

really cool feature!

@toolbear

Nice. Only the "difference" view when image is resized is a little wonky looking.

@nathanbertram

Good stuff!

@enathu

Really a awesome feature. Nice. Like the 'Onion Skin' view. :)

@jballanc

"Difference" view on resized image reminds me of 2001: A Space Odyssey. Otherwise, very very cool!

@barmstrong

Impressive!

@kidpollo

This is great guys thank u

@azer

so cool! thanks a lot

@johndbritton

AMAZING

@jarodreyes

Please now! I want to go to there!

@kennethreitz

The UI for switching between comparison modes is extremely elegant. Fantastic work, :octocat:!

@the-kenny

Love the octocat pictures

@passy

Incredibly useful!

@adamdicarlo

Outstanding! I've been wanting something like this, though unsure of exactly how it should work, for a long time.

@misterkeeter

hoorayzors!

@kevinholesh

Amazingly easy-to-use. Very well done! A+++

@jasonmelgoza

Sweet!

@huynguyen

Now I can solve all those 'spot the difference' games. Bwhahahah!

@bobbytables

This is awesome.

@marcamillion

I love Github. This is pretty epic.

@mtodd

Stumbled upon this on Saturday I think... was surprised and thought I'd missed the official announcement! :) Great job.

@mtodd

Err, that is, I noticed the image diff for the first time on Saturday, at all. These additional ways to view diffs is, truly, baller.

@mtodd

Finally, difference with different sizes is fucking trippy. :)

@frozzare

Very nice guys!

@gduplessy

Really Cool!! Great job!

@kirkegaard

oh wow! Amazing job! Perfect

@nmunson

Awesome! Very helpful.

@mt3

ok. i didn't get it until i checked the demo. damn nice.

@alfyboza

Absolutely awesome!

@morganick

high five

@Surgo

awesome!

@pedrohr

NICE!!!!!

@erisdev

This is pretty brilliant! Suddenly the diff view for images is useful. :D

@collin

So pretty much we need to teach our designers to deliver iterations as jpgs in git. Right?

That's how I'm reading this.

@paulshapiro

Okay that's just awesome.

@MarioRicalde

awesome.

@jzting

fantastic!

@mrdoob

I like!

@teknikqa

brilliant!

@vikstrous

This is amazing. I should start using github for everything.

@zackdouglas

Awesome. Anything but "2 up" looks a bit awkward when comparing different sized versions, though.

@railsfactory

besides PNG are you planning to support other image formats?

@anildigital

awesome!

@momania

awesome!

@nvie

Oh man, this is truly awesome.

@jasiek

Cool, this is going to be really useful for me. When I saw the post on HN I immediately thought: 'pdiff', but this is even better.

@aronwoost

So cool!

@johan

Improvement suggestion: instead of the images jumping around vertically a bit when switching between modes, because of the different relative positions and sizes of the extra UI elements you add / remove (for drag handles), could you just allocate enough vertical space (padding / margin) for either mode's UI components in all four modes, so the image can remain in the same location when you switch between them? (2-up, of course, would just retain the vertical image position during mode switches.)

@vestel

Super!
What about making notes on images as well?
Thanks!

@janmoesen

Nice!

Was it intentional to change the first image (1_normal) from JPEG to PNG? The other way round could produce a lot of difference due to compression artifacts, obviously.

@chrleon

Wicked cool, but I don't know if it's for demopurposes or if it's incorrect: The transparent diff doesn't show the dropshadow in the alpha.Only the outline.

@myszek123

Cool!

@arnklint

Nice!

@seankoole

Awesome stuff, keep it up!

@jbbarquero

Impressive!

@og2t

Awesome feature, it would be nice to lock the image click so you can't drag it out accidentally.

@est

nextup make winrar diff

@aviflax

SO GREAT!

@ncr

wow

@kerryfalk

Are these features also available through GitHub:Fi?

@cameronmcefee

@kerryfalk FI usually lags a little behind, but it will get the view modes eventually.

@kerryfalk

Excellent! Thank you.

@neodevelop

WTF! guys, you're the best...

@cookiemonster

Absolutely awesome!

@richlove1

Very cool!

@xster

good god

@vredniy

It's awesome, github rulez :]

@jessegreathouse

HAY WUTS GOING ON IN HERE?

@jgyllen

wow. cool stuff!

@pokonski

Amazingly awesome, as Jobs would say!

@haqu

nice indeed

@eamonnmag

Way cool.

@d2s

Certainly, this is great thing to have. :)

Combines features similar to Kaleidoscope to GitHub and makes this service feel much more full versed for web designers. :)

@green-coder

Génial !

@ChrisFilou

This is absolutly usefull!

@nickdunn

Cool story, bro

@gorimaru

画像diffまでできるのか…すごすぎる!

@eamonnmag

^ Exactly! :)

@mrdoob

I wish github allowed unsubscribing from any thread. Kind of makes you wish you never wrote that comment...

@pokonski

@mrdoob, you can do that :P Check at the bottom of this page:

Email notifications for these commit notes are on. Disable email notifications for this commit

@mrdoob

I'm not talking about emails. I'm talking about notifications.

I already have all email disabled, but I still get a notification inside github when someone writes in this thread with no option to unsubscribe.

Hope it's clear now.

@saymoon

soo cool, great job!

@liuxun349

oh,yeah!so cool

@goldenlove

Good job~

@BenBergman

This looks great, but I can't seem to click the buttons to change mode. In Chromium on Arch Linux and Chrome/"Browser" on Android 4.0.1, the buttons are vertically stacked and not clickable. On Firefox in Arch Linux, the buttons aren't even there.

@cameronmcefee

@BenBergman, looks like accidentally broke it. I'll see if we can get that fixed asap.

@cameronmcefee

@BenBergman Thanks for the heads up. It should be back in action again.

@BenBergman

Well, I spoke too soon. The demo doesn't work, but my own repo does.

Edit: I see you just happened to fix it between me checking your repo and mine. Thanks for the quick fix!

@mrdoob

@cameronmcefee While you're at it, can you make it so one can unsubscribe from threads? Thanks!

@yimi128

WOW! cool

@mrdoob

Oh wow. They just added the feature. Thanks @github!

/me happily unwatches this thread.

@github
@hidoos

so cool!

@zlcolin

wow, so great.

@Awesomez

awesome !

@lashou-hxh

very good

@willddy

awesome

@hiramtan

不错……

@inchyea

Awesome;

@wenxiongli

very good

@haihappen

Where did the difference mode go?

@ottijp

attractive!

@Alexhust

Pretty Good!

@duguying

wow :smile: pretty! is there any demo for psd files?

@jsw0528

强帖留名

@hoosin

给力啊

@aditx

Cool :)

@xiaojuntong

niubilitily

@tomeanand

awesome!

@fengsp

So cool!

@VTwo-Group

Awesome! واقعا شگفت انگیزه.

@gindis

Cool!

@huanglong

Good job!

@King-fly

非常不错

@emir

awesome!

@wasfever

nice!

@ThomasAy

Guys, it's been 3 years ! Where is this awesome feature ?

@ipa-fmw-ms

Will there be support for more than two diffs? (like 10 or so)
I would love to see a range of commits in the onion mode

@ziolau

awesome

@luck2011

really

@EllenXi

cool

@wangkailang

on the way

@sunapi386

wunderbar

@shangguangjie

very cool

@tf-best

cool

@robertwbradford

Good stuff. @cameronmcefee, is there a roadmap for supporting other file formats? .ai files would be really great!

@longhua

It is great!

@Domonlee

It is great!

@stevezeng

这个太好了

@BuddyZH

very good

@dongzi2014

so cool

@woodlou

cool~

@istro

SO awesome. I just discovered it accidentally when I changed some images. Nice surprise. Thanks guys, you rock!!!

@iqiancheng

amazing!

@MarsCWD

prefect!!!

@xsd0720

wow!

@kkd927

awesome!!

@anton-matosov

super cool image diff!!

@xxg3053

nice!

@wy2005

漂亮

Please sign in to comment.
Something went wrong with that request. Please try again.