Permalink
Browse files

Image View Mode Demo

1 parent 8bf009f commit 8e95f70c9c47168305970e91021072673d7cdad8 Cameron McEfee committed Mar 18, 2011
View
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
View
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
View
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

167 comments on commit 8e95f70

@rubiii
rubiii commented on 8e95f70 Mar 21, 2011

wow :)

@floere
floere commented on 8e95f70 Mar 21, 2011

Nice :)

@tvandervossen

Sexy. Would be nice if you could also just click and drag inside the image to change the Swipe and Onion Skin sliders. They’re a bit fiddly now.

@pjvds
pjvds commented on 8e95f70 Mar 21, 2011

Awesome!

@isaachall

I hear that in the next release will contain a slider to control how many of your bugs GitHub automatically corrects for you.

@SunboX
SunboX commented on 8e95f70 Mar 21, 2011

really cool feature!

@toolbear

Nice. Only the "difference" view when image is resized is a little wonky looking.

@nathanbertram

Good stuff!

@enathu
enathu commented on 8e95f70 Mar 21, 2011

Really a awesome feature. Nice. Like the 'Onion Skin' view. :)

@jballanc

"Difference" view on resized image reminds me of 2001: A Space Odyssey. Otherwise, very very cool!

@barmstrong

Impressive!

@kidpollo

This is great guys thank u

@azer
azer commented on 8e95f70 Mar 21, 2011

so cool! thanks a lot

@johndbritton

AMAZING

@jarodreyes

Please now! I want to go to there!

@kennethreitz

The UI for switching between comparison modes is extremely elegant. Fantastic work, :octocat:!

@the-kenny

Love the octocat pictures

@passy
passy commented on 8e95f70 Mar 21, 2011

Incredibly useful!

@adamdicarlo

Outstanding! I've been wanting something like this, though unsure of exactly how it should work, for a long time.

@misterkeeter

hoorayzors!

@kevinholesh

Amazingly easy-to-use. Very well done! A+++

@jasonmelgoza

Sweet!

@huynguyen

Now I can solve all those 'spot the difference' games. Bwhahahah!

@bobbytables

This is awesome.

@marcamillion

I love Github. This is pretty epic.

@mtodd
mtodd commented on 8e95f70 Mar 21, 2011

Stumbled upon this on Saturday I think... was surprised and thought I'd missed the official announcement! :) Great job.

@mtodd
mtodd commented on 8e95f70 Mar 21, 2011

Err, that is, I noticed the image diff for the first time on Saturday, at all. These additional ways to view diffs is, truly, baller.

@mtodd
mtodd commented on 8e95f70 Mar 21, 2011

Finally, difference with different sizes is fucking trippy. :)

@frozzare

Very nice guys!

@gduplessy

Really Cool!! Great job!

@kirkegaard

oh wow! Amazing job! Perfect

@nmunson

Awesome! Very helpful.

@mt3
mt3 commented on 8e95f70 Mar 22, 2011

ok. i didn't get it until i checked the demo. damn nice.

@ricardoquesada

nice!

@alfyboza

Absolutely awesome!

@morganick

high five

@Surgo
Surgo commented on 8e95f70 Mar 22, 2011

awesome!

@pedrohr

NICE!!!!!

@erisdev

This is pretty brilliant! Suddenly the diff view for images is useful. :D

@collin
collin commented on 8e95f70 Mar 22, 2011

So pretty much we need to teach our designers to deliver iterations as jpgs in git. Right?

That's how I'm reading this.

@paulshapiro

Okay that's just awesome.

@MarioRicalde

awesome.

@jzting
jzting commented on 8e95f70 Mar 22, 2011

fantastic!

@mrdoob
mrdoob commented on 8e95f70 Mar 22, 2011

I like!

@teknikqa

brilliant!

@vikstrous

This is amazing. I should start using github for everything.

@zackdouglas

Awesome. Anything but "2 up" looks a bit awkward when comparing different sized versions, though.

@railsfactory

besides PNG are you planning to support other image formats?

@anildigital

awesome!

@momania

awesome!

@nvie
nvie commented on 8e95f70 Mar 22, 2011

Oh man, this is truly awesome.

@jasiek
jasiek commented on 8e95f70 Mar 22, 2011

Cool, this is going to be really useful for me. When I saw the post on HN I immediately thought: 'pdiff', but this is even better.

@aronwoost

So cool!

@johan
johan commented on 8e95f70 Mar 22, 2011

Improvement suggestion: instead of the images jumping around vertically a bit when switching between modes, because of the different relative positions and sizes of the extra UI elements you add / remove (for drag handles), could you just allocate enough vertical space (padding / margin) for either mode's UI components in all four modes, so the image can remain in the same location when you switch between them? (2-up, of course, would just retain the vertical image position during mode switches.)

@vestel
vestel commented on 8e95f70 Mar 22, 2011

Super!
What about making notes on images as well?
Thanks!

@janmoesen

Nice!

Was it intentional to change the first image (1_normal) from JPEG to PNG? The other way round could produce a lot of difference due to compression artifacts, obviously.

@ariusleechihin

Like!

@chrleon

Wicked cool, but I don't know if it's for demopurposes or if it's incorrect: The transparent diff doesn't show the dropshadow in the alpha.Only the outline.

@stettberger

WOW

@myszek123

Cool!

@arnklint

Nice!

@seankoole

Awesome stuff, keep it up!

@jbbarquero

Impressive!

@og2t
og2t commented on 8e95f70 Mar 22, 2011

Awesome feature, it would be nice to lock the image click so you can't drag it out accidentally.

@est
est commented on 8e95f70 Mar 22, 2011

nextup make winrar diff

@aviflax

SO GREAT!

@ncr
ncr commented on 8e95f70 Mar 22, 2011

wow

@kerryfalk

Are these features also available through GitHub:Fi?

@cameronmcefee
Owner

@kerryfalk FI usually lags a little behind, but it will get the view modes eventually.

@kerryfalk

Excellent! Thank you.

@neodevelop

WTF! guys, you're the best...

@cookiemonster

Absolutely awesome!

@richlove1

Very cool!

@xster
xster commented on 8e95f70 Mar 23, 2011

good god

@vredniy

It's awesome, github rulez :]

@jessegreathouse

HAY WUTS GOING ON IN HERE?

@jgyllen

wow. cool stuff!

@eddiejaoude

@github LOVE IT!

@pokonski

Amazingly awesome, as Jobs would say!

@haqu
haqu commented on 8e95f70 Apr 18, 2011

nice indeed

@eamonnmag

Way cool.

@d2s
d2s commented on 8e95f70 Apr 30, 2011

Certainly, this is great thing to have. :)

Combines features similar to Kaleidoscope to GitHub and makes this service feel much more full versed for web designers. :)

@green-coder

Génial !

@ChrisFilou

This is absolutly usefull!

@nickdunn

Cool story, bro

@gorimaru

画像diffまでできるのか…すごすぎる!

@eamonnmag

^ Exactly! :)

@mrdoob
mrdoob commented on 8e95f70 Oct 27, 2011

I wish github allowed unsubscribing from any thread. Kind of makes you wish you never wrote that comment...

@pokonski

@mrdoob, you can do that :P Check at the bottom of this page:

Email notifications for these commit notes are on. Disable email notifications for this commit

@mrdoob
mrdoob commented on 8e95f70 Oct 27, 2011

I'm not talking about emails. I'm talking about notifications.

I already have all email disabled, but I still get a notification inside github when someone writes in this thread with no option to unsubscribe.

Hope it's clear now.

@kirkegaard

+1!

@saymoon
saymoon commented on 8e95f70 Nov 2, 2011

soo cool, great job!

@mrdoob
mrdoob commented on 8e95f70 Nov 2, 2011

FFS @github!

@liuxun349

oh,yeah!so cool

@goldenlove

Good job~

@BenBergman

This looks great, but I can't seem to click the buttons to change mode. In Chromium on Arch Linux and Chrome/"Browser" on Android 4.0.1, the buttons are vertically stacked and not clickable. On Firefox in Arch Linux, the buttons aren't even there.

@cameronmcefee
Owner

@BenBergman, looks like accidentally broke it. I'll see if we can get that fixed asap.

@cameronmcefee
Owner

@BenBergman Thanks for the heads up. It should be back in action again.

@BenBergman

Well, I spoke too soon. The demo doesn't work, but my own repo does.

Edit: I see you just happened to fix it between me checking your repo and mine. Thanks for the quick fix!

@mrdoob
mrdoob commented on 8e95f70 May 12, 2012

@cameronmcefee While you're at it, can you make it so one can unsubscribe from threads? Thanks!

@yimi128
yimi128 commented on 8e95f70 Aug 1, 2012

WOW! cool

@mrdoob
mrdoob commented on 8e95f70 Aug 6, 2012

FFS @github!

@mrdoob
mrdoob commented on 8e95f70 Aug 6, 2012

Oh wow. They just added the feature. Thanks @github!

/me happily unwatches this thread.

@github
github commented on 8e95f70 Aug 7, 2012
@hidoos
hidoos commented on 8e95f70 Aug 22, 2012

so cool!

@zlcolin
zlcolin commented on 8e95f70 Jan 8, 2013

wow, so great.

@Awesomez

awesome !

@lashou-hxh

very good

@willddy

awesome

@hiramtan

不错……

@inchyea

Awesome;

@wenxiongli

very good

@ream88
ream88 commented on 8e95f70 Apr 23, 2014

Where did the difference mode go?

@ottijp
ottijp commented on 8e95f70 Apr 28, 2014

attractive!

@MartinDelille

👍

@Alexhust

Pretty Good!

@duguying

wow 😄 pretty! is there any demo for psd files?

@jsw0528
jsw0528 commented on 8e95f70 Jun 6, 2014

强帖留名

@hoosin
hoosin commented on 8e95f70 Jun 6, 2014

给力啊

@aditx
aditx commented on 8e95f70 Jun 7, 2014

Cool :)

@xiaojuntong

niubilitily

@tomeanand

awesome!

@fengsp
fengsp commented on 8e95f70 Jun 9, 2014

So cool!

@VTwo-Group

Awesome! واقعا شگفت انگیزه.

@gindis
gindis commented on 8e95f70 Jun 10, 2014

Cool!

@huanglong

Good job!

@King-fly

非常不错

@emir
emir commented on 8e95f70 Jun 17, 2014

awesome!

@wasfever

nice!

@ThomasAy

Guys, it's been 3 years ! Where is this awesome feature ?

@ipa-fmw-ms

Will there be support for more than two diffs? (like 10 or so)
I would love to see a range of commits in the onion mode

@ziolau
ziolau commented on 8e95f70 Jul 19, 2014

awesome

@luck2011

really

@EllenXi

cool

@wangkailang

on the way

@sunapi386

wunderbar

@taotao9125

wow

@shangguangjie

very cool

@tf-best

cool

@leehung-witkey

cool

@robertwbradford

Good stuff. @cameronmcefee, is there a roadmap for supporting other file formats? .ai files would be really great!

@longhua

It is great!

@Domonlee

It is great!

@stevezeng

这个太好了

@BuddyZH

very good

@lisiqiong

so cool

@woodlou

cool~

@istro
istro commented on 8e95f70 Mar 19, 2015

SO awesome. I just discovered it accidentally when I changed some images. Nice surprise. Thanks guys, you rock!!!

@iqiancheng

amazing!

@MarsCWD
MarsCWD commented on 8e95f70 Jul 2, 2015

prefect!!!

@xsd0720
xsd0720 commented on 8e95f70 Jul 3, 2015

wow!

@kkd927
kkd927 commented on 8e95f70 Jul 27, 2015

awesome!!

@anton-matosov

super cool image diff!!

@xxg3053

nice!

@wy2005
wy2005 commented on 8e95f70 Aug 31, 2015

漂亮

@linkinparkzlz

cool

@zhendongguan

amazing!!!

@Antony138

Awesome!

@LineToAnyWhere

cool!

@hungryfoolisher

awesome!

@soberzhou

It's so awesome !
BTW, i hope can support .psd & .sketch

@kuangyun

so great!

@AdamQwy

The function is so cool! BUT!

where's the module of Difference .
I just saw the illustration at the blog titled Behold: Image view modes . And it guided me here.
This picture is what I copyed form the blog.
image
Did you guys remove this mode.
I thought it's the coolest mode.
What a pity 😞

@snowluliang

This is awesome

@xsd0720
@bluzioo
bluzioo commented on 8e95f70 Dec 4, 2016

Cool, it's impressive

Please sign in to comment.