Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Image View Mode Demo

commit 8e95f70c9c47168305970e91021072673d7cdad8 1 parent 8bf009f
Cameron McEfee authored
BIN  1_normal.jpg
View
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
BIN  2_transparentPixels.png
View
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
BIN  3_tooLarge.jpg
View
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
BIN  4_differentSize.jpg
View
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

149 comments on commit 8e95f70

Daniel Harrington

wow :)

Florian R. Hanke

Nice :)

Thijs van der Vossen

Sexy. Would be nice if you could also just click and drag inside the image to change the Swipe and Onion Skin sliders. They’re a bit fiddly now.

Pieter Joost van de Sande

Awesome!

Isaac Hall

I hear that in the next release will contain a slider to control how many of your bugs GitHub automatically corrects for you.

André Fiedler

really cool feature!

Tim Taylor

Nice. Only the "difference" view when image is resized is a little wonky looking.

Nathan Bertram

Good stuff!

Tharique Azeez

Really a awesome feature. Nice. Like the 'Onion Skin' view. :)

Joshua Ballanco

"Difference" view on resized image reminds me of 2001: A Space Odyssey. Otherwise, very very cool!

Brian Armstrong

Impressive!

Francisco Viramontes

This is great guys thank u

Azer Koçulu

so cool! thanks a lot

John Britton

AMAZING

Jarod Reyes

Please now! I want to go to there!

Kenneth Reitz

The UI for switching between comparison modes is extremely elegant. Fantastic work, :octocat:!

Moritz Ulrich

Love the octocat pictures

Pascal Hartig

Incredibly useful!

Adam DiCarlo

Outstanding! I've been wanting something like this, though unsure of exactly how it should work, for a long time.

Mckee Frazior

hoorayzors!

Kevin Holesh

Amazingly easy-to-use. Very well done! A+++

Jason Melgoza

Sweet!

Huy Nguyen

Now I can solve all those 'spot the difference' games. Bwhahahah!

Robert Ross

This is awesome.

Marc Gayle

I love Github. This is pretty epic.

Matt Todd

Stumbled upon this on Saturday I think... was surprised and thought I'd missed the official announcement! :) Great job.

Matt Todd

Err, that is, I noticed the image diff for the first time on Saturday, at all. These additional ways to view diffs is, truly, baller.

Matt Todd

Finally, difference with different sizes is fucking trippy. :)

Fredrik Forsmo

Very nice guys!

Georges Duplessy

Really Cool!! Great job!

Christian Kirkegaard

oh wow! Amazing job! Perfect

Nicholas Munson

Awesome! Very helpful.

mt3

ok. i didn't get it until i checked the demo. damn nice.

Alfonso Boza

Absolutely awesome!

Nick Morgan

high five

Kosei Kitahara

awesome!

Pedro Henrique Ribeiro de Assis

NICE!!!!!

Eris

This is pretty brilliant! Suddenly the diff view for images is useful. :D

collin

So pretty much we need to teach our designers to deliver iterations as jpgs in git. Right?

That's how I'm reading this.

Paul Shapiro

Okay that's just awesome.

Mario Ricalde

awesome.

Jason Ting

fantastic!

Mr.doob

I like!

Nick Mathew

brilliant!

Viktor Stanchev

This is amazing. I should start using github for everything.

Zack Douglas

Awesome. Anything but "2 up" looks a bit awkward when comparing different sized versions, though.

RailsFactory

besides PNG are you planning to support other image formats?

Anil Wadghule

awesome!

Irmo Manie

awesome!

Vincent Driessen

Oh man, this is truly awesome.

Jan Szumiec

Cool, this is going to be really useful for me. When I saw the post on HN I immediately thought: 'pdiff', but this is even better.

Aron Woost

So cool!

Johan Sundström

Improvement suggestion: instead of the images jumping around vertically a bit when switching between modes, because of the different relative positions and sizes of the extra UI elements you add / remove (for drag handles), could you just allocate enough vertical space (padding / margin) for either mode's UI components in all four modes, so the image can remain in the same location when you switch between them? (2-up, of course, would just retain the vertical image position during mode switches.)

Aleksandrs Zdancuks

Super!
What about making notes on images as well?
Thanks!

Jan Moesen

Nice!

Was it intentional to change the first image (1_normal) from JPEG to PNG? The other way round could produce a lot of difference due to compression artifacts, obviously.

Christian Leon Christensen

Wicked cool, but I don't know if it's for demopurposes or if it's incorrect: The transparent diff doesn't show the dropshadow in the alpha.Only the outline.

myszek123

Cool!

Jonas Arnklint

Nice!

Sean Koole

Awesome stuff, keep it up!

Javier

Impressive!

Tomek Augustyn

Awesome feature, it would be nice to lock the image click so you can't drag it out accidentally.

est

nextup make winrar diff

Avi Flax

SO GREAT!

Jacek Becela

wow

Kerry Falk

Are these features also available through GitHub:Fi?

Cameron McEfee

@kerryfalk FI usually lags a little behind, but it will get the view modes eventually.

Kerry Falk

Excellent! Thank you.

José Juan Reyes Zuñiga

WTF! guys, you're the best...

cookiemonster

Absolutely awesome!

Rich Lovelock

Very cool!

xster

good god

Dmitry Zudochkin

It's awesome, github rulez :]

Jesse Greathouse

HAY WUTS GOING ON IN HERE?

Jacob Gyllenstierna

wow. cool stuff!

Piotr Okoński

Amazingly awesome, as Jobs would say!

Sergey Tikhonov

nice indeed

Eamonn Maguire

Way cool.

Daniel Schildt

Certainly, this is great thing to have. :)

Combines features similar to Kaleidoscope to GitHub and makes this service feel much more full versed for web designers. :)

Vincent Cantin

Génial !

ChrisFilou

This is absolutly usefull!

Nick Dunn

Cool story, bro

ゴリ丸

画像diffまでできるのか…すごすぎる!

Eamonn Maguire

^ Exactly! :)

Mr.doob

I wish github allowed unsubscribing from any thread. Kind of makes you wish you never wrote that comment...

Piotr Okoński

@mrdoob, you can do that :P Check at the bottom of this page:

Email notifications for these commit notes are on. Disable email notifications for this commit

Mr.doob

I'm not talking about emails. I'm talking about notifications.

I already have all email disabled, but I still get a notification inside github when someone writes in this thread with no option to unsubscribe.

Hope it's clear now.

saymoon

soo cool, great job!

LLH

oh,yeah!so cool

Peter

Good job~

Benjamin Bergman

This looks great, but I can't seem to click the buttons to change mode. In Chromium on Arch Linux and Chrome/"Browser" on Android 4.0.1, the buttons are vertically stacked and not clickable. On Firefox in Arch Linux, the buttons aren't even there.

Cameron McEfee

@BenBergman, looks like accidentally broke it. I'll see if we can get that fixed asap.

Cameron McEfee

@BenBergman Thanks for the heads up. It should be back in action again.

Benjamin Bergman

Well, I spoke too soon. The demo doesn't work, but my own repo does.

Edit: I see you just happened to fix it between me checking your repo and mine. Thanks for the quick fix!

Mr.doob

@cameronmcefee While you're at it, can you make it so one can unsubscribe from threads? Thanks!

yimi128

WOW! cool

Mr.doob

Oh wow. They just added the feature. Thanks @github!

/me happily unwatches this thread.

GitHub
hidoos

so cool!

ZL Colin

wow, so great.

Raymon Zhang

awesome !

黄孝辉

very good

Will Du

awesome

hiramtan

不错……

Inchyea

Awesome;

SamLee

very good

Mario Uher

Where did the difference mode go?

otti

attractive!

alexhust

Pretty Good!

Rex Lee

wow :smile: pretty! is there any demo for psd files?

wǒ_is神仙

强帖留名

给力

给力啊

Aditya Putra Indrayanto

Cool :)

xiaojuntong

niubilitily

Anand Vimalanathan

awesome!

Shipeng Feng

So cool!

VTwo Group

Awesome! واقعا شگفت انگیزه.

gindis

Cool!

Scott Dong

Good job!

Jack

非常不错

Emir Karşıyakalı

awesome!

wasfever

nice!

ThomasAy

Guys, it's been 3 years ! Where is this awesome feature ?

ipa-fmw-ms

Will there be support for more than two diffs? (like 10 or so)
I would love to see a range of commits in the onion mode

ziolau

awesome

luck2011

really

EllenXi

cool

王开朗

on the way

Jason Sun

wunderbar

shangguangjie

very cool

tf-best

cool

Robert Bradford

Good stuff. @cameronmcefee, is there a roadmap for supporting other file formats? .ai files would be really great!

LongHua Huang

It is great!

Domon

It is great!

stevezeng

这个太好了

BuddyZH

very good

peterlee

so cool

wood

cool~

Please sign in to comment.
Something went wrong with that request. Please try again.