Fix false negatives#31
Conversation
Reading the Playwright documentation, I realised I wasn't using the BrowserContext feature which "allows creating isolated non-persistent browser contexts … which don't write any browsing data to disk."
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Code Review
This pull request aims to fix false negatives in bookmark processing. It introduces several changes: reducing concurrency, improving liveness checks in the headless browser to correctly handle HTTP error codes, and adding more logging for redirects. The test suite has been updated to reflect changes in the code structure. The review focuses on potential issues with performance, code clarity, and test coverage.
a81a785 to
4d0e9d9
Compare
Co-authored-by: aider (gemini/gemini-2.5-flash) <aider@aider.chat>
4d0e9d9 to
0b97cf7
Compare
There was a problem hiding this comment.
Code Review
This pull request improves the liveness checks by using Playwright browser contexts and by handling HTTP error status codes in the headless browser check. The tests have been updated accordingly. There is a performance issue with using a Prefect task as a Playwright event handler, which could lead to excessive task creation. I've provided a suggestion to convert it to a regular function.
As identified by gemini-code-assist PR review.
Co-authored-by: aider (gemini/gemini-2.5-pro) <aider@aider.chat>
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request refactors the headless browser check to use Playwright's BrowserContext for better isolation and correctly treats HTTP 4xx/5xx status codes as failures, which should help fix false positives. The accompanying tests have been updated and expanded to cover these changes.
Overall, the changes are well-implemented and the new tests are thorough. I've left a couple of suggestions to improve code clarity and test maintainability.
As suggested by Google Code Assist PR review. Co-authored-by: aider (gemini/gemini-2.5-pro) <aider@aider.chat>
As suggested by Gemini Code Assist PR review.
1 participant
The point of opening this PR was to test the Gemini Code Assist GitHub integration. I will keep it updated and eventually land the changes I need to make (fixing the false negatives) but for now it's WIP.