Permalink
Browse files

Integration test for large data set of poker hands, fix requires

  • Loading branch information...
camillebaldock committed Sep 8, 2014
1 parent 167c0f8 commit 3f49c5a1a52c230230f88a86cebd3862fd8d4260
Showing with 43 additions and 82 deletions.
  1. +0 −2 lib/card_as_two_integers_parser.rb
  2. +0 −2 lib/hand.rb
  3. +0 −2 lib/hand_string_parser.rb
  4. +1 −0 spec/hand_spec.rb
  5. +0 −76 spec/spec_helper.rb
  6. +42 −0 test_rankings_large_data_set.rb
@@ -1,5 +1,3 @@
-require "errors"
-
class CardAsTwoIntegersParser
def parse(array_suit_pips)
View
@@ -1,5 +1,3 @@
-require "card"
-
class Hand
include ArrayHelper
include Comparable
@@ -1,5 +1,3 @@
-require "errors"
-
class HandStringParser
#Parser for hands written as documented in:
#https://archive.ics.uci.edu/ml/machine-learning-databases/poker/poker-hand.names
View
@@ -2,6 +2,7 @@
require 'hand'
require 'hand_array_parser'
require 'card_parser'
+require 'card'
describe Hand do
View
@@ -1,78 +1,2 @@
-# This file was generated by the `rspec --init` command. Conventionally, all
-# specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
-# The generated `.rspec` file contains `--require spec_helper` which will cause this
-# file to always be loaded, without a need to explicitly require it in any files.
-#
-# Given that it is always loaded, you are encouraged to keep this file as
-# light-weight as possible. Requiring heavyweight dependencies from this file
-# will add to the boot time of your test suite on EVERY test run, even for an
-# individual file that may not need all of that loaded. Instead, make a
-# separate helper file that requires this one and then use it only in the specs
-# that actually need it.
-#
-# The `.rspec` file also contains a few flags that are not defaults but that
-# users commonly want.
-#
-# See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
RSpec.configure do |config|
-# The settings below are suggested to provide a good initial experience
-# with RSpec, but feel free to customize to your heart's content.
-=begin
- # These two settings work together to allow you to limit a spec run
- # to individual examples or groups you care about by tagging them with
- # `:focus` metadata. When nothing is tagged with `:focus`, all examples
- # get run.
- config.filter_run :focus
- config.run_all_when_everything_filtered = true
-
- # Many RSpec users commonly either run the entire suite or an individual
- # file, and it's useful to allow more verbose output when running an
- # individual spec file.
- if config.files_to_run.one?
- # Use the documentation formatter for detailed output,
- # unless a formatter has already been configured
- # (e.g. via a command-line flag).
- config.default_formatter = 'doc'
- end
-
- # Print the 10 slowest examples and example groups at the
- # end of the spec run, to help surface which specs are running
- # particularly slow.
- config.profile_examples = 10
-
- # Run specs in random order to surface order dependencies. If you find an
- # order dependency and want to debug it, you can fix the order by providing
- # the seed, which is printed after each run.
- # --seed 1234
- config.order = :random
-
- # Seed global randomization in this process using the `--seed` CLI option.
- # Setting this allows you to use `--seed` to deterministically reproduce
- # test failures related to randomization by passing the same `--seed` value
- # as the one that triggered the failure.
- Kernel.srand config.seed
-
- # rspec-expectations config goes here. You can use an alternate
- # assertion/expectation library such as wrong or the stdlib/minitest
- # assertions if you prefer.
- config.expect_with :rspec do |expectations|
- # Enable only the newer, non-monkey-patching expect syntax.
- # For more details, see:
- # - http://myronmars.to/n/dev-blog/2012/06/rspecs-new-expectation-syntax
- expectations.syntax = :expect
- end
-
- # rspec-mocks config goes here. You can use an alternate test double
- # library (such as bogus or mocha) by changing the `mock_with` option here.
- config.mock_with :rspec do |mocks|
- # Enable only the newer, non-monkey-patching expect syntax.
- # For more details, see:
- # - http://teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
- mocks.syntax = :expect
-
- # Prevents you from mocking or stubbing a method that does not exist on
- # a real object. This is generally recommended.
- mocks.verify_partial_doubles = true
- end
-=end
end
@@ -0,0 +1,42 @@
+#Download 'poker-hand-testing.data' dataset from http://archive.ics.uci.edu/ml/datasets/Poker+Hand.
+#Execute this script with path to the data file as the first argument.
+#
+#bundle exec ruby test_rankings_large_data_set.rb ~/Downloads/poker-hand-testing.data
+
+require_relative 'lib/card_as_two_integers_parser'
+require_relative 'lib/errors'
+require_relative 'lib/hand_string_parser'
+require_relative 'lib/array_helper'
+require_relative 'lib/hand'
+require_relative 'lib/card'
+
+RANKS =
+{
+ 0 => :highest,
+ 1 => :pair,
+ 2 => :two_pair,
+ 3 => :three_of_a_kind,
+ 4 => :straight,
+ 5 => :flush,
+ 6 => :full_house,
+ 7 => :four_of_a_kind,
+ 8 => :straight_flush,
+ 9 => :royal_flush,
+}
+
+data_file = ARGV[0]
+
+File.new(data_file).each do |line|
+ cards = line.chop.chop
+ expected_rank_integer = line.split(",").last.to_i
+ expected_rank = RANKS.fetch(expected_rank_integer)
+
+ card_parser = CardAsTwoIntegersParser.new
+ hand_parser = HandStringParser.new(card_parser)
+ hand = Hand.new(cards, hand_parser)
+ rank = hand.rank.fetch(:type)
+
+ if rank != expected_rank
+ puts "Inconsistency found in: #{line}, expected #{expected_rank} got #{rank}"
+ end
+end

0 comments on commit 3f49c5a

Please sign in to comment.