Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add install instructions, remove unused kmer.cc file #2

Merged
merged 4 commits into from Mar 10, 2019

Conversation

Projects
None yet
2 participants
@luizirber
Copy link
Contributor

luizirber commented Mar 9, 2019

These install instructions work on these systems:

  • Ubuntu 16.04.5 LTS, gcc (Ubuntu 5.5.0-12ubuntu1~16.04) 5.5.0 20171010
  • Arch Linux, gcc (GCC) 8.2.1 20181127
     boink/include/boink/storage/partitioned_storage.hh:163:8: error: too many template-parameter-lists
           struct is_probabilistic<PartitionedStorage<StorageType>> {
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    
  • on macOS the PREFIX variable is not defined in dodo.py. Will not try to fix because I don't really care about macs =]

Changes:

  • I removed src/boink/kmers/kmer.cc because it was messing up the build (there is no include/boink/kmers/kmer.hh to go with it)
  • cqf tasks were using a hardcoded _libbuild, using LIBBUILDDIR instead
  • +x for scripts/build-ukhs-signatures
@camillescott

This comment has been minimized.

Copy link
Owner

camillescott commented Mar 10, 2019

Cool! macOS isn't actually supported anyway, because I ended up adding third-party dependencies that won't build on it.

The Arch error is pretty weird though?

@camillescott camillescott merged commit 49f6e4d into camillescott:master Mar 10, 2019

@luizirber

This comment has been minimized.

Copy link
Contributor Author

luizirber commented Mar 10, 2019

@luizirber luizirber referenced this pull request Mar 10, 2019

Merged

building on macos #3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.