Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

building on macos #3

Merged
merged 3 commits into from Mar 11, 2019

Conversation

Projects
None yet
2 participants
@luizirber
Copy link
Contributor

luizirber commented Mar 10, 2019

  • move some variables around in dodo.py
  • use SHARED_EXT to figure out proper extension (.so or `.dylib)
  • macOS sed doesn't have same options as GNU sed, so need to use gsed on mac (or make it compatible with macOS sed) seems like it was related to the line break? weird... but working now.

with these changes it get the same error from #2 in Arch, with gcc-8.

@luizirber

This comment has been minimized.

Copy link
Contributor Author

luizirber commented Mar 10, 2019

(and for some reason I can't unmark it as a draft PR? tsc github)

@camillescott

This comment has been minimized.

Copy link
Owner

camillescott commented Mar 11, 2019

Gotcha, thanks! I'll merge and do some investigating on the gcc-8 error.

@camillescott camillescott marked this pull request as ready for review Mar 11, 2019

@camillescott camillescott merged commit ebff194 into camillescott:master Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.