From afb355330cc212815c07b0d1d94c7e7ecacb62da Mon Sep 17 00:00:00 2001 From: Tushar Madhukar Date: Tue, 19 Jun 2018 14:22:39 +1000 Subject: [PATCH] Migration to API v3.2 - fix review comments --- lib/createsend/subscriber.rb | 2 +- test/subscriber_test.rb | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/createsend/subscriber.rb b/lib/createsend/subscriber.rb index b426371..7a99d21 100644 --- a/lib/createsend/subscriber.rb +++ b/lib/createsend/subscriber.rb @@ -38,7 +38,7 @@ def self.add(auth, list_id, email_address, name, custom_fields, resubscribe, end # Imports subscribers into a subscriber list. - def self.import(auth, list_id, subscribers, resubscribe, + def self.import(auth, list_id, subscribers, resubscribe, queue_subscription_based_autoresponders=false, restart_subscription_based_autoresponders=false) options = { :body => { diff --git a/test/subscriber_test.rb b/test/subscriber_test.rb index 4e56266..93e1c29 100644 --- a/test/subscriber_test.rb +++ b/test/subscriber_test.rb @@ -77,7 +77,7 @@ class SubscriberTest < Test::Unit::TestCase { :EmailAddress => "example+2@example.com", :Name => "Example Two" }, { :EmailAddress => "example+3@example.com", :Name => "Example Three" }, ] - import_result = CreateSend::Subscriber.import @auth, @list_id, subscribers, true, "No" + import_result = CreateSend::Subscriber.import @auth, @list_id, subscribers, true import_result.FailureDetails.size.should == 0 import_result.TotalUniqueEmailsSubmitted.should == 3 import_result.TotalExistingSubscribers.should == 0 @@ -92,7 +92,7 @@ class SubscriberTest < Test::Unit::TestCase { :EmailAddress => "example+2@example.com", :Name => "Example Two" }, { :EmailAddress => "example+3@example.com", :Name => "Example Three" }, ] - import_result = CreateSend::Subscriber.import @auth, @list_id, subscribers, true, "No", true + import_result = CreateSend::Subscriber.import @auth, @list_id, subscribers, true, true import_result.FailureDetails.size.should == 0 import_result.TotalUniqueEmailsSubmitted.should == 3 import_result.TotalExistingSubscribers.should == 0 @@ -107,7 +107,7 @@ class SubscriberTest < Test::Unit::TestCase { :EmailAddress => "example+2@example.com", :Name => "Example Two", :CustomFields => [ { :Key => 'website', :Value => '', :Clear => false } ] }, { :EmailAddress => "example+3@example.com", :Name => "Example Three", :CustomFields => [ { :Key => 'website', :Value => '', :Clear => false } ] }, ] - import_result = CreateSend::Subscriber.import @auth, @list_id, subscribers, true, "No" + import_result = CreateSend::Subscriber.import @auth, @list_id, subscribers, true import_result.FailureDetails.size.should == 0 import_result.TotalUniqueEmailsSubmitted.should == 3 import_result.TotalExistingSubscribers.should == 0 @@ -123,7 +123,7 @@ class SubscriberTest < Test::Unit::TestCase { :EmailAddress => "example+2@example.com", :Name => "Example Two" }, { :EmailAddress => "example+3@example.com", :Name => "Example Three" }, ] - import_result = CreateSend::Subscriber.import @auth, @list_id, subscribers, true, "No" + import_result = CreateSend::Subscriber.import @auth, @list_id, subscribers, true import_result.FailureDetails.size.should == 1 import_result.FailureDetails.first.EmailAddress.should == "example+1@example" import_result.FailureDetails.first.Code.should == 1 @@ -142,8 +142,8 @@ class SubscriberTest < Test::Unit::TestCase { :EmailAddress => "example+2@example.com", :Name => "Example Two" }, { :EmailAddress => "example+3@example.com", :Name => "Example Three" }, ] - lambda { import_result = CreateSend::Subscriber.import @auth, @list_id, subscribers, true, "Yes" - }.should raise_error(CreateSend::BadRequest) + lambda { import_result = CreateSend::Subscriber.import @auth, @list_id, subscribers, + true }.should raise_error(CreateSend::BadRequest) end should "unsubscribe a subscriber" do