Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devel #159

Merged
merged 38 commits into from
May 10, 2019
Merged

Devel #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
ea13d5e
Merge pull request #146 from zhewa/master
zhewa Apr 29, 2019
8537904
fix lints
zhewa Apr 30, 2019
b28014d
Merge pull request #150 from zhewa/master
zhewa Apr 30, 2019
507bea5
bump x.y.z versions to even y prior to creation of RELEASE…
nturaga May 2, 2019
b2a7991
bump x.y.z versions to odd y after creation of RELEASE_3_9 branch
nturaga May 2, 2019
8b30f35
fix .validateCounts bug
zhewa May 2, 2019
f67a7d0
Merge pull request #153 from zhewa/master
zhewa May 2, 2019
e57d594
Update README.md
zhewa May 4, 2019
0a053d7
Update README.md
zhewa May 4, 2019
fa7bb07
Fix normalization in moduleHeatmap(). Fixes #154
definitelysean May 7, 2019
4b88508
Update StateHeatmap.R
definitelysean May 7, 2019
519b739
Updating documentation for new param change. #154
definitelysean May 7, 2019
ec231be
Fixing broken unit tests.
definitelysean May 7, 2019
75aaeae
Merge pull request #155 from definitelysean/master
zhewa May 7, 2019
0327e44
fix lints
zhewa May 8, 2019
77fc09b
add with_seed to celda_C.R
zhewa May 8, 2019
c358fce
add with_seed to celda_CG.R
zhewa May 8, 2019
a8254b8
add with_seed to celda_G.R
zhewa May 9, 2019
7365c4e
add with_seed to decon.R
zhewa May 9, 2019
f6a2aa7
add with_seed to model_performance.R
zhewa May 9, 2019
fd95d0e
update documentation
zhewa May 9, 2019
2638918
add withr to DESCRIPTION
zhewa May 9, 2019
c2a1031
fix celdaTsne for celda_C bug
zhewa May 9, 2019
a915e15
fix beta in decon.R
zhewa May 9, 2019
3961d4a
celdaCCim -> celdaCSim
zhewa May 9, 2019
787ad7d
add unit tests for seed setting
zhewa May 9, 2019
2f490ae
update vignettes
zhewa May 9, 2019
6331ab0
fix lints
zhewa May 9, 2019
e89f415
fix lint
zhewa May 9, 2019
f2cf84d
Merge pull request #157 from zhewa/silentSeeds
zhewa May 9, 2019
663db78
Merge branch 'RELEASE_3_9' of git.bioconductor.org:packages/celda int…
zhewa May 9, 2019
3cf0ba7
update NEWS
zhewa May 9, 2019
d764d1a
Merge branch 'silentSeeds' of https://github.com/campbio/celda into R…
zhewa May 9, 2019
c9a31df
Merge pull request #158 from zhewa/RELEASE_3_9
zhewa May 9, 2019
c543c55
Merge branch 'RELEASE_3_9' of https://github.com/campbio/celda into d…
zhewa May 10, 2019
588696f
update decon.R
zhewa May 10, 2019
7e88931
Merge branch 'master' of git.bioconductor.org:packages/celda into devel
zhewa May 10, 2019
cd873ed
update DESCRIPTION and NEWS
zhewa May 10, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions DESCRIPTION
100755 → 100644
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: celda
Title: CEllular Latent Dirichlet Allocation
Version: 0.99.39
Version: 1.1.1
Authors@R: c(person("Joshua", "Campbell", email = "camp@bu.edu", role = c("aut", "cre")),
person("Sean", "Corbett", email = "scorbett@bu.edu", role = c("aut")),
person("Yusuke", "Koga", email="ykoga07@bu.edu", role = c("aut")),
Expand Down Expand Up @@ -38,7 +38,8 @@ Imports:
SummarizedExperiment,
MCMCprecision,
ggrepel,
Rtsne
Rtsne,
withr
Suggests:
testthat,
knitr,
Expand Down
1 change: 1 addition & 0 deletions NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ importFrom(scales,hue_pal)
importFrom(stringi,stri_list2matrix)
importFrom(umap,umap)
importFrom(umap,umap.defaults)
importFrom(withr,with_seed)
useDynLib(celda,"_colSumByGroup")
useDynLib(celda,"_colSumByGroupChange")
useDynLib(celda,"_colSumByGroup_numeric")
Expand Down
15 changes: 10 additions & 5 deletions R/StateHeatmap.R
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,13 @@
#' @param topFeatures Integer. Plot `topFeatures` with the highest probability
#' in the featureModule. If NULL, plot all features in the module. Default
#' NULL.
#' @param normalize Logical. Whether to normalize the columns of `counts`.
#' Default TRUE.
#' @param normalizedCounts Integer matrix. Rows represent features and columns
#' represent cells. This matrix should correspond to the one provided for
#' `counts`, but should be passed through. If NA, normalize `counts`.
#' Default NA.
#' `normalizeCounts(counts, "proportion", transformationFun=sqrt)`. Use of this
#' parameter is particularly useful for plotting many moduleHeatmaps, where
#' normalizing the counts matrix repeatedly would be too time consuming.
#' @param scaleRow Character. Which function to use to scale each individual
#' row. Set to NULL to disable. Occurs after normalization and log
#' transformation. For example, `scale` will Z-score transform each row.
Expand All @@ -39,7 +44,7 @@ moduleHeatmap <- function(counts,
featureModule = 1,
topCells = 100,
topFeatures = NULL,
normalize = TRUE,
normalizedCounts = NA,
scaleRow = scale,
showFeaturenames = TRUE) {

Expand Down Expand Up @@ -93,11 +98,11 @@ moduleHeatmap <- function(counts,
}

cellIndices <- rev(cellIndices)
if (normalize) {
if (is.na(normalizedCounts)) {
normCounts <- normalizeCounts(counts, normalize = "proportion",
transformationFun = sqrt)
} else {
normCounts <- counts
normCounts <- normalizedCounts
}

# filter counts based on featureIndices
Expand Down
5 changes: 4 additions & 1 deletion R/all_generics.R
Original file line number Diff line number Diff line change
Expand Up @@ -601,9 +601,11 @@ setGeneric("celdaTsne",
#' for umap. Default 20.
#' @param modules Integer vector. Determines which features modules to use for
#' tSNE. If NULL, all modules will be used. Default NULL.
#' @param seed Integer. Passed to \link[withr]{with_seed}. For reproducibility,
#' a default value of 12345 is used. If NULL, no calls to
#' \link[withr]{with_seed} are made.
#' @param umapConfig An object of class "umapConfig" specifying parameters to
#' the UMAP algorithm.
#' @param ... Additional parameters.
#' @return Numeric Matrix of dimension `ncol(counts)` x 2, colums representing
#' the "X" and "Y" coordinates in the data's t-SNE represetation.
#' @examples
Expand All @@ -619,6 +621,7 @@ setGeneric("celdaUmap",
minClusterSize = 100,
initialDims = 20,
modules = NULL,
seed = 12345,
umapConfig = umap::umap.defaults) {
standardGeneric("celdaUmap")
})
Expand Down
Loading