Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

The next block #26

Closed
wants to merge 36 commits into from

2 participants

@joewalker
Collaborator

No description provided.

joewalker added some commits
@joewalker joewalker Bug 678152 (beautify): Prompt fix 1
Move the completion element resize code to be an event.
Better division of labor. Also see next commit.
4baadb3
@joewalker joewalker Bug 720641 (toolbar): Separate out prompt handling.
Sometimes resize needs to be handled by GCLI, sometimes not
1de3ee8
@joewalker joewalker Bug 720641 (toolbar): Have completer use XUL
We needed to tweak default namespace in setContents from XHTML
to the namespace of the document to which we are adding.
We might need a custom namespace param one day
08fa373
@joewalker joewalker Bug 725239 (settings): Fix settings
Have GCLI prefs use 'devtools.gcli.' prefix only in firefox
Cache list of settings
2a2719b
@joewalker joewalker Bug 726986 (help): Remove cause of undefined warning 09e1f1d
@joewalker joewalker Bug 720641 (toolbar): Minor fixes
Ensure CSS files don't get into build
Add class to completer so we can style better
Fix missing 'this.' so we reference the document properly
deea2b5
@joewalker joewalker Bug 731957 (ontense): Avoid naming clashes
With the old naming convention, were were getting name clashes.
This prevents this in some case, but more changes before everything is
done the same way.
73e556f
@joewalker joewalker Bug 720641 (toolbar): Be more helpful about when to show the panels. 861ddaa
@joewalker joewalker Bug 732780 (view): Extract common features of output listeners
Now they both use the same 'to DOM code'
fa6bde0
@joewalker joewalker Bug 732780 (view): Add a createView function
Encapsulates a template, and the settings needed to run it
Leaving the actual running to 'display-time'.
d5b21d4
@joewalker joewalker Bug 732777 (safeset): Add an 'allowSet' pref
First use of createView.
Includes tweak to requisition.exec to allow use of command not in object
4c91090
@joewalker joewalker Bug 732777 (safeset): Fix Intro to not use command
The addition of a safety catch for 'pref set' broke intro which exec'ed
'pref set showIntro false' in order to get started.
So this alters the setting directly.
Also creates output using createView() and thus simplifies the param list
82877ce
@joewalker joewalker Bug 720641 (toolbar): Update tooltip on content changes
The browser needs to re-calculate the height on each change
Also tucked in here is a minor documenation update
141dc39
@joewalker joewalker Bug 732780 (view): Fix potential memory leak
We were not removing a listener properly
76607b6
@joewalker joewalker Bug 732793 (connector): Add in connector d26af38
@joewalker joewalker Bug 729514 (exec): Various tidy-ups:
Listen on localhost only, not all interfaces, for security
Put the logger into development mode
Remove the testApp testing function
Add comment
d77fc60
@joewalker joewalker Bug 729514 (exec): Extend OS command system to JS functions
Includes some redirection of console back to the browser
84e5c8f
@joewalker joewalker Bug 729514 (exec): Add a trivial build command e10fc31
@joewalker joewalker Bug 729514 (exec): Better styling for terminal output e7c84c0
@joewalker joewalker Bug 720641 (toolbar): Fix several minor issues:
- Remove strict warnings
- Add missing documentation
- Ensure functions either return something or don't
- Remove console logging
- Rename 2 functions in display for less wrapping
d8a04db
@joewalker joewalker Bug 720641 (toolbar): Refactor CSS
The same code previously handled the panel and the menu. Firefox has it's
own panel, so we rename and refactor to clarify the distinction, and allow
us to cleanly not use the panel code in Firefox.
cf288aa
@joewalker joewalker Bug 720641 (toolbar): The prompt looked too big e43175d
@joewalker joewalker Bug 729514 (exec): Use express not connect for better routing
Also allows the use of socket.io.
[Change does not affect firefox code]
3334eaa
@joewalker joewalker Bug 720641 (toolbar): Fix several minor issues:
- startup functions are called startup not setup
- remove unused import
12b16cc
@joewalker joewalker Bug 729514 (exec): Make gcli gentler on browser implementation
- Node doesn't define HTMLElement
- or localStorage
- or navigator
e323b94
@joewalker joewalker Bug 733768 (execobj): Return outputObject not boolean cfc0a17
@joewalker joewalker Bug 720641 (toolbar): CSS tweaks for firefox
- Don't add padding in CSS, in firefox we need separate values for the
  input element and completion element, and JS styling was never nice
- .gcli-in-valid is for valid parts of the typed text, not the whole thing
- Make things look nicer
b647419
@joewalker joewalker Bug 732780 (view): Use views for 'help'
- The templates no longer use navigator.language
- Merge help_intro and help_list using includeIntro property
a49727f
@joewalker joewalker Bug 720641 (toolbar): Styling tweaks for firefox
- Use &#160; (i.e. nbsp) in place of ' ' because <description> seems to
  remove them when they're next to <label>s
2083cae
@joewalker joewalker Bug 733794 (buildslice): Cut up build file. (Non-FF)
This code doesn't go into Firefox.
855cf1e
@joewalker joewalker Bug 734031 (intro): s/node-main/gcli
'node-main' was always a strange name, since this now runs and embedded
gcli, as well as the web server, it makes sense to call it gcli. Also it
completes better as node-main clashed with node_modules.
1e383dd
@joewalker joewalker Bug 734031 (intro): Various documentation tweaks e15aef9
@joewalker joewalker Bug 734031 (intro): Make sure all tests run from CLI: Display
We refactored startup to expose a limitted set of things. Too limitted for
testing, so create a class called Display and expose that separately.
This also makes the naming more rational - there is no View/Display
confusion, and especially good in that we have something else called View.
It affects an exposed API, but a deprecation proxy is provided.
697a72e
@joewalker joewalker Bug 734031 (intro): Ensure all tests run in all environments. 2ead070
@joewalker joewalker Bug 734205 (cssfreejsm): Use createCssIgnoreFilter
- Rename createIgnoreFilter to createCssIgnoreFilter because it's just
  about CSS
- Use it when building gclichrome.jsm
6269b99
@joewalker joewalker Bug 720641 (toolbar): DeveloperToolbar can do this for itself
- We should consider deleting OutputSingle from the tree because it
  isn't currently used anywhere
3d1dca8
@campd
Owner

r+ on beautify

@campd

Can you not just use &nbsp;?

Collaborator

Not in XHTML

@campd
Owner

r+ on (toolbar)

@campd
Owner

r+ on (settings)

@campd
Owner

r+ on (help)

@campd
Owner

r+ on (ontense)

@campd
Owner

r+ on (view), good change.

@campd
Owner

r+ on (safeset)

@campd
Owner

r+ on (exec) and (execobj)

@campd
Owner

r+ on (cssfreejsm). I think that's everything.

@joewalker joewalker closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 29, 2012
  1. @joewalker

    Bug 678152 (beautify): Prompt fix 1

    joewalker authored
    Move the completion element resize code to be an event.
    Better division of labor. Also see next commit.
  2. @joewalker

    Bug 720641 (toolbar): Separate out prompt handling.

    joewalker authored
    Sometimes resize needs to be handled by GCLI, sometimes not
  3. @joewalker

    Bug 720641 (toolbar): Have completer use XUL

    joewalker authored
    We needed to tweak default namespace in setContents from XHTML
    to the namespace of the document to which we are adding.
    We might need a custom namespace param one day
Commits on Mar 1, 2012
  1. @joewalker

    Bug 725239 (settings): Fix settings

    joewalker authored
    Have GCLI prefs use 'devtools.gcli.' prefix only in firefox
    Cache list of settings
  2. @joewalker
  3. @joewalker

    Bug 720641 (toolbar): Minor fixes

    joewalker authored
    Ensure CSS files don't get into build
    Add class to completer so we can style better
    Fix missing 'this.' so we reference the document properly
  4. @joewalker

    Bug 731957 (ontense): Avoid naming clashes

    joewalker authored
    With the old naming convention, were were getting name clashes.
    This prevents this in some case, but more changes before everything is
    done the same way.
  5. @joewalker
Commits on Mar 4, 2012
  1. @joewalker

    Bug 732780 (view): Extract common features of output listeners

    joewalker authored
    Now they both use the same 'to DOM code'
  2. @joewalker

    Bug 732780 (view): Add a createView function

    joewalker authored
    Encapsulates a template, and the settings needed to run it
    Leaving the actual running to 'display-time'.
  3. @joewalker

    Bug 732777 (safeset): Add an 'allowSet' pref

    joewalker authored
    First use of createView.
    Includes tweak to requisition.exec to allow use of command not in object
  4. @joewalker

    Bug 732777 (safeset): Fix Intro to not use command

    joewalker authored
    The addition of a safety catch for 'pref set' broke intro which exec'ed
    'pref set showIntro false' in order to get started.
    So this alters the setting directly.
    Also creates output using createView() and thus simplifies the param list
  5. @joewalker

    Bug 720641 (toolbar): Update tooltip on content changes

    joewalker authored
    The browser needs to re-calculate the height on each change
    Also tucked in here is a minor documenation update
  6. @joewalker

    Bug 732780 (view): Fix potential memory leak

    joewalker authored
    We were not removing a listener properly
  7. @joewalker
Commits on Mar 5, 2012
  1. @joewalker

    Bug 729514 (exec): Various tidy-ups:

    joewalker authored
    Listen on localhost only, not all interfaces, for security
    Put the logger into development mode
    Remove the testApp testing function
    Add comment
  2. @joewalker

    Bug 729514 (exec): Extend OS command system to JS functions

    joewalker authored
    Includes some redirection of console back to the browser
  3. @joewalker
  4. @joewalker
  5. @joewalker

    Bug 720641 (toolbar): Fix several minor issues:

    joewalker authored
    - Remove strict warnings
    - Add missing documentation
    - Ensure functions either return something or don't
    - Remove console logging
    - Rename 2 functions in display for less wrapping
Commits on Mar 6, 2012
  1. @joewalker

    Bug 720641 (toolbar): Refactor CSS

    joewalker authored
    The same code previously handled the panel and the menu. Firefox has it's
    own panel, so we rename and refactor to clarify the distinction, and allow
    us to cleanly not use the panel code in Firefox.
  2. @joewalker
  3. @joewalker

    Bug 729514 (exec): Use express not connect for better routing

    joewalker authored
    Also allows the use of socket.io.
    [Change does not affect firefox code]
Commits on Mar 7, 2012
  1. @joewalker

    Bug 720641 (toolbar): Fix several minor issues:

    joewalker authored
    - startup functions are called startup not setup
    - remove unused import
  2. @joewalker

    Bug 729514 (exec): Make gcli gentler on browser implementation

    joewalker authored
    - Node doesn't define HTMLElement
    - or localStorage
    - or navigator
  3. @joewalker
  4. @joewalker

    Bug 720641 (toolbar): CSS tweaks for firefox

    joewalker authored
    - Don't add padding in CSS, in firefox we need separate values for the
      input element and completion element, and JS styling was never nice
    - .gcli-in-valid is for valid parts of the typed text, not the whole thing
    - Make things look nicer
  5. @joewalker

    Bug 732780 (view): Use views for 'help'

    joewalker authored
    - The templates no longer use navigator.language
    - Merge help_intro and help_list using includeIntro property
  6. @joewalker

    Bug 720641 (toolbar): Styling tweaks for firefox

    joewalker authored
    - Use &#160; (i.e. nbsp) in place of ' ' because <description> seems to
      remove them when they're next to <label>s
  7. @joewalker

    Bug 733794 (buildslice): Cut up build file. (Non-FF)

    joewalker authored
    This code doesn't go into Firefox.
Commits on Mar 8, 2012
  1. @joewalker

    Bug 734031 (intro): s/node-main/gcli

    joewalker authored
    'node-main' was always a strange name, since this now runs and embedded
    gcli, as well as the web server, it makes sense to call it gcli. Also it
    completes better as node-main clashed with node_modules.
  2. @joewalker
  3. @joewalker

    Bug 734031 (intro): Make sure all tests run from CLI: Display

    joewalker authored
    We refactored startup to expose a limitted set of things. Too limitted for
    testing, so create a class called Display and expose that separately.
    This also makes the naming more rational - there is no View/Display
    confusion, and especially good in that we have something else called View.
    It affects an exposed API, but a deprecation proxy is provided.
  4. @joewalker
  5. @joewalker

    Bug 734205 (cssfreejsm): Use createCssIgnoreFilter

    joewalker authored
    - Rename createIgnoreFilter to createCssIgnoreFilter because it's just
      about CSS
    - Use it when building gclichrome.jsm
  6. @joewalker

    Bug 720641 (toolbar): DeveloperToolbar can do this for itself

    joewalker authored
    - We should consider deleting OutputSingle from the tree because it
      isn't currently used anywhere
Something went wrong with that request. Please try again.