Bug 726986 (help) #44

Closed
wants to merge 8 commits into
from

Conversation

Projects
None yet
2 participants
@joewalker
Collaborator

joewalker commented May 22, 2012

Incorporating Bug 725237 (introtext)

joewalker added some commits May 22, 2012

Bug 726986 (help): Merge .gcli-help-synopsis to .gcli-out-shortcut
We don't need 2 virtually identical classes with identical uses.
Merge them.
Bug 726986 (help): Update look
Remove use of monospaced fonts like in firefox. Plus some other minor
visual tweaks.
Note: This change set does not reach Firefox.
See following commit for minor visual tweak that does reach Firefox.
Bug 726986 (help): Update look
Remove use of monospaced fonts like in firefox. Plus some other minor
visual tweaks.
Bug 726986 (help): Fix broken 'help' link in intro
The problem is that the mechanism for clickable command links is all in
help.js and not shared like it should be. We shared the CSS code a few
commits ago, now it's the JS.
- Extract executeCommand() and updateCommand() to util
- Use the data-command attribute rather than trying to guess based on the
  textContent, which was buggy anyway
- Move the click to only the highlighed region, full row was confusing
Bug 726986 (help): Add describe() function to help
Simplifies picking item.description vs item.manual.
Allows use of HTML markup, previously was used, but not supported
@campd

This comment has been minimized.

Show comment
Hide comment
@campd

campd May 24, 2012

Maybe we shouldn't be calling it an 'experiment' in shipping code either?

campd commented on 2a6c3ac May 24, 2012

Maybe we shouldn't be calling it an 'experiment' in shipping code either?

@campd

This comment has been minimized.

Show comment
Hide comment
@campd

campd May 24, 2012

Owner

r+, but can you file a bug to have UX look at the GCLI introduction text?

Owner

campd commented May 24, 2012

r+, but can you file a bug to have UX look at the GCLI introduction text?

Bug 726986 (help): Internationalize the intro text.
Now reads:
"The Firefox command line is designed for developers. It focuses on speed
of input over JavaScript syntax and a rich display over monospace output.
For a list of commands type 'help' or to show/hide command hints press
'F1/Escape'.
[Got it!]"
@joewalker

This comment has been minimized.

Show comment
Hide comment
@joewalker

joewalker May 25, 2012

Collaborator
Collaborator

joewalker commented May 25, 2012

Bug 726986 (help): Merge createView code
There were 2 versions of createView for intro, one that missed out l10n
functions, as a result of a copy/paste error. Merge the 2 implementations.
Also adjust the tests to fit.
@campd

This comment has been minimized.

Show comment
Hide comment
@campd

campd May 29, 2012

Owner

r+ on additions.

Owner

campd commented May 29, 2012

r+ on additions.

@joewalker joewalker closed this May 29, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment