Simplify flag.Usage implementation. #12
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary
os.Exit
call. Theflag
package is responsible for doing that.You can look at the default implementation of
flag.Usage
and confirm it doesn't callos.Exit(2)
either:Also see mdempsky/unconvert@3b9aa41 and shurcooL-legacy/backlog#4.
This is a really minor thing, but many people will be looking at this code, so I'm happy to help contribute improvements to style so that other people have a better example to learn/copy from (plus, I don't wanna have to keep making these PRs on even more repos 馃槈).