Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix incorrect prop name in Layertree widget #132

Merged
merged 3 commits into from Jul 4, 2012

Conversation

Projects
None yet
2 participants
Member

asaunier commented Jul 3, 2012

The name of the property containing the WMS layers general options has recently been changed from wmsOptions to wmsConfig in the code section defining the WMS overlays - but not in the class properties list. If it is not on purpose, I suggest to go back to wmsOptions because OL doc talks about "options" (not "config") + to avoid breaking existing projects using the old prop name.

By the way, I have fixed the prop API doc to make them appear in http://docs.camptocamp.net/cgxp/lib/widgets/tree/LayerTree.html

@elemoine elemoine commented on an outdated diff Jul 4, 2012

core/src/script/CGXP/widgets/tree/LayerTree.js
@@ -62,7 +62,7 @@ cgxp.tree.LayerTree = Ext.extend(Ext.tree.TreePanel, {
/** api: config[frienlyUrl]
* ``Boolean``
- * True to enable friendly url support (HTML5 browers only), default to true.
+ * True to enable friendly URL support (HTML5 browers only), default to true.
@elemoine

elemoine Jul 4, 2012

Contributor

browers -> browsers (while you're at it)

Contributor

elemoine commented Jul 4, 2012

Please merge. Thanks.

@asaunier asaunier added a commit that referenced this pull request Jul 4, 2012

@asaunier asaunier Merge pull request #132 from camptocamp/layertree-wmsoptions
Fix incorrect prop name in Layertree widget
d62ab17

@asaunier asaunier merged commit d62ab17 into master Jul 4, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment