Add new gmf.source.Swisstopo #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredj
force-pushed
the
swisstopo_source
branch
from
cf5733e
to
a4739db
Compare
|
Is this now ready for review? |
|
not yet: I want to test it in a project before. Note that this source has no example because of the access restriction |
|
Some docs about the access restrictions would be nice. |
fredj
force-pushed
the
swisstopo_source
branch
from
a4739db
to
e1785f5
Compare
fredj
force-pushed
the
swisstopo_source
branch
from
e1785f5
to
8c6790d
Compare
| * The `Time` dimension of the source. | ||
| * @type {string} | ||
| */ | ||
| gmfx.source.SwisstopoOptions.prototype.timestamp; |
There was a problem hiding this comment.
Could this be put just after the AsitVDOptions source?
fredj
force-pushed
the
swisstopo_source
branch
from
8c6790d
to
484b32a
Compare
| */ | ||
| gmf.source.Swisstopo = function(options) { | ||
|
|
||
| var format = options.format ? options.format : 'png'; |
There was a problem hiding this comment.
You're declaring the format variable but not using it afterwards.
fredj
force-pushed
the
swisstopo_source
branch
from
484b32a
to
a1151ce
Compare
| goog.base(this, { | ||
| attributions: [gmf.source.Swisstopo.ATTRIBUTION_], | ||
| url: 'https://wmts{5-9}.geo.admin.ch/1.0.0/{Layer}/default/{Time}' + | ||
| '/21781/{TileMatrix}/{TileRow}/{TileCol}.' + options.format, |
fredj
force-pushed
the
swisstopo_source
branch
from
a1151ce
to
f1d44f7
Compare
|
Thanks for the review @pgiraud |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
work in progress
Fixes #328