Skip to content

missing implementation about unique #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
item4 opened this issue Jan 13, 2016 · 5 comments
Closed

missing implementation about unique #73

item4 opened this issue Jan 13, 2016 · 5 comments

Comments

@item4
Copy link
Contributor

item4 commented Jan 13, 2016

See 932 line. What is Sizzle's API?

There is no impl, only misplaced text :(
@item4
Copy link
Contributor Author

item4 commented Jan 13, 2016

I think we can use Set of innerHTML of each element.

@camsong
Copy link
Owner

camsong commented Jan 13, 2016

where is the line 932?

@item4
Copy link
Contributor Author

item4 commented Jan 13, 2016

@camsong https://github.com/oneuijs/You-Dont-Need-jQuery/blob/master/README.md#6.2 see unique util

@camsong
Copy link
Owner

camsong commented Jan 13, 2016

@arcthur

@camsong
Copy link
Owner

camsong commented Jan 15, 2016

We found that there are rare occasions that need to use unique when play with Virtual DOM, and this method rely on DOM manipulation heavily, so I will remove it for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@arcthur @item4 @camsong