This repository was archived by the owner on Apr 21, 2022. It is now read-only.
Add parameter to allow customization of indentation #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The indentation is hard coded as a tab ("\t") character, which is not
always desirable. The prettify method should have a parameter that
allows the caller to pass the indentation string to be used.
| * @return string The prettified json string | ||
| */ | ||
| protected function process($json) | ||
| protected function process($json, $indentation = "\t") |
There was a problem hiding this comment.
Minor change. Can you name this $indent?
|
Thanks @hglattergotz this is a great change. I will merge if you can make that minor change 👍 |
|
That change would conflict with the internal $indent variable in the |
|
That would be perfect. It is just consistency that I am wanting, so any way to make is consistent is fine. |
camspiers
added a commit
that referenced
this pull request
Aug 27, 2013
Add parameter to allow customization of indentation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The indentation is hard coded as a tab ("\t") character, which is not
always desirable. The prettify method should have a parameter that
allows the caller to pass the indentation string to be used.
Add parameter with default value so any existing code is not broken.