Apply event sourcing to message publish processor #6376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saig0
force-pushed
the
6178-message-publish
branch
from
df249f6
to
c902242
Compare
Zelldon
reviewed
Feb 22, 2021
There was a problem hiding this comment.
Thanks @saig0 I added some questions which would be cool if we discuss them before. Tbh it was a bit confusing for me that we introduced the CORRELATING for message subscritptions and have the CORRELATED for message start subscriptions 😅 and yes I have read the ZEP, but it doesn't make it more clearer.
protocol/src/main/java/io/zeebe/protocol/record/value/MessageRecordValue.java
Outdated
Show resolved
Hide resolved
engine/src/main/java/io/zeebe/engine/state/appliers/MessagePublishedApplier.java
Show resolved
Hide resolved
...main/java/io/zeebe/engine/state/appliers/MessageStartEventSubscriptionCorrelatedApplier.java
Show resolved
Hide resolved
| messageState.put(message); | ||
|
|
||
| // avoid correlating this message to the workflow again | ||
| correlatingSubscriptions.visitBpmnProcessIds( |
There was a problem hiding this comment.
I assume we write for all of them the follow up events?
There was a problem hiding this comment.
- insert message in state: https://github.com/zeebe-io/zeebe/blob/c9022428e0c0eb3c9f2df3d2395690a1e7bb3420/engine/src/main/java/io/zeebe/engine/state/appliers/MessagePublishedApplier.java#L38
- insert message correlation: https://github.com/zeebe-io/zeebe/blob/c9022428e0c0eb3c9f2df3d2395690a1e7bb3420/engine/src/main/java/io/zeebe/engine/state/appliers/MessageSubscriptionCorrelatingApplier.java#L48
- insert correlation for message start event: https://github.com/zeebe-io/zeebe/blob/c9022428e0c0eb3c9f2df3d2395690a1e7bb3420/engine/src/main/java/io/zeebe/engine/state/appliers/MessageStartEventSubscriptionCorrelatedApplier.java#L34
|
🛎️ @Zelldon do you have more questions? |
* use the state writer in the message publish processor to apply the state changes * extend the ES templates for the new record properties * disable the replay filter to restore the key generator for migrated processors
saig0
force-pushed
the
6178-message-publish
branch
from
634c1af
to
e421bc4
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
EventHandleto share the common behavior to trigger start eventsdeadlinevariablesworkflowInstanceKey,messageKey,correlationKey,variablesCORRELATINGCORRELATEDHints for the reviewer:
Related issues
The last part of #6178.
closes #6178
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/0.25) to the PR, in case that fails you need to create backports manually.Testing:
Documentation: