Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(polling): cancel scheduled timer on error #8424

Merged
1 commit merged into from
Dec 20, 2021
Merged

Conversation

romansmirnov
Copy link
Member

@romansmirnov romansmirnov commented Dec 17, 2021

Description

  • Cancel scheduled timer on error

Related issues

closes #8423

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/0.25) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement

Copy link
Member

@lenaschoenburg lenaschoenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you! 🏅

@lenaschoenburg
Copy link
Member

bors r+

@ghost
Copy link

ghost commented Dec 20, 2021

Build succeeded:

@ghost ghost merged commit a3dfe67 into develop Dec 20, 2021
@ghost ghost deleted the 8423-cancel-scheduled-timer branch December 20, 2021 12:26
@github-actions
Copy link
Contributor

Successfully created backport PR #8443 for stable/1.1.

@github-actions
Copy link
Contributor

Successfully created backport PR #8444 for stable/1.2.

ghost pushed a commit that referenced this pull request Dec 20, 2021
8444: [Backport stable/1.2] fix(polling): cancel scheduled timer on error r=oleschoenburg a=github-actions[bot]

# Description
Backport of #8424 to `stable/1.2`.

relates to #8423

Co-authored-by: Roman <roman.smirnov@camunda.com>
ghost pushed a commit that referenced this pull request Dec 20, 2021
8443: [Backport stable/1.1] fix(polling): cancel scheduled timer on error r=oleschoenburg a=github-actions[bot]

# Description
Backport of #8424 to `stable/1.1`.

relates to #8423

Co-authored-by: Roman <roman.smirnov@camunda.com>
@lenaschoenburg

This comment has been minimized.

@lenaschoenburg

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Activate Jobs Request scheduled Timer is not canceled on error
3 participants