Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Conditional Flow Rule #5

Closed
MuffinMICHI opened this issue Sep 13, 2019 · 2 comments · Fixed by #6

Comments

@MuffinMICHI
Copy link

commented Sep 13, 2019

The rule should detect the following modeling patterns

The proposed rule should detect, if a condition for every outgoing path of a gateway is set. The rule should display an error immediately after modelling the outgoing sequence paths of a gateway.

How does the rule improve the BPMN diagram?

The benefit of this rule is, that people immediately see, if their outgoing paths of a gateway are configured or not. If a condition is not set, the mistake mostly occurs after deploying and executing the process for the first time. This rule prevents, that process with gateways are modeled, where the outgoing paths of a gateway do not have a condition defined. Furthermore this rule helps people to learn, how the decisions at a gateway are defined, since every outgoing path should contain a condition.

Rule Details

  • Name: gateway-conditions
  • Default notification level: error

What alternatives did you consider?

An alternative to this propose is the existing rule "conditional-flows.js".
But if a gateway with outgoing sequence flows is modeled, this rule does not tell you, that the conditions for the paths are not set. Only if you set a condition for the first path, it tells you, that the conditions for the other paths are not set. The missing conditions are not displayed right away.

nikku added a commit that referenced this issue Sep 13, 2019
Closes #5
@wuffle-app wuffle-app bot added the in progress label Sep 13, 2019
@nikku nikku referenced this issue Sep 13, 2019
2 of 2 tasks complete
@nikku

This comment has been minimized.

Copy link
Member

commented Sep 13, 2019

I've added a work-in-progress PR on this: #6.

@nikku nikku removed the in progress label Sep 16, 2019
@wuffle-app wuffle-app bot added the needs review label Sep 16, 2019
@nikku

This comment has been minimized.

Copy link
Member

commented Oct 4, 2019

Closed via #6.

@nikku nikku closed this Oct 4, 2019
@wuffle-app wuffle-app bot removed the needs review label Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.