Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch for the wildlfy subsystem for WF 14 (possibly 12 and 13) #306

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@kifj
Copy link

commented Sep 5, 2018

The changes allow to build and run the Camunda BPM for a current Wildfly version.
The actual wildfly subsystem won't compile with Wildfy 14 (probably 12 & 13 too), due to changes in the configuration model. This adresses CAM-8934 (https://app.camunda.com/jira/browse/CAM-8934)

I assume the best way would be to have 2 wildfly subsystems, one covering the current supported versions and a second one for the newer Wildfly versions, but this would need more work to be spent in the current maven setup of the project - which I'm not sure if I understood it correctly.

I've built and tested this with Wildfly 14 successfully.

@yanavasileva

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2018

Hi Joe,

Thanks for the contribution.
We will check it next week and return back to you with feedback.

Best regards,
Yana

@koevskinikola

This comment has been minimized.

Copy link
Member

commented Sep 17, 2018

Hi @kifj,

I already reviewed your pull request last week. It's awesome, thanks for the contribution!

However, it breaks support for WildFly 8 and we still need to provide support for that. Because of this, we decided to move the subsystem with your changes to WildFly 10 and keep the old subsystem in WildFly 8. This will result in new Maven coordinates for WildFly 8 users.

I'm still working on making the needed changes for this, so I'll keep the ticket open until everything is finished.

Cheers,
Nikola

@kifj

This comment has been minimized.

Copy link
Author

commented Sep 17, 2018

Hi @koevskinikola

Thank you, I expected something like this, and that this pull request may need more rework to be able to have 2 different subsystems for the different wildfy versions.

koevskinikola added a commit that referenced this pull request Sep 19, 2018

feat(engine): support latest wildfly version
* Patch the wildlfy subsystem for WildFly 14 (and 12,13)

Related to CAM-8934, #306
@koevskinikola

This comment has been minimized.

Copy link
Member

commented Oct 10, 2018

Hi @kifj,

I'm closing this PR since I made the necessary changes needed for everything to function properly. The project structure will still change, since from now on, we'll cover only the latest version of WildFly in our tests.

Thanks again for the contribution. It really sped things up.

Cheers,
Nikola

@kifj

This comment has been minimized.

Copy link
Author

commented Oct 10, 2018

Thank you

@kifj kifj deleted the kifj:7.9.0-wildfly14 branch Oct 10, 2018

@alacambra

This comment has been minimized.

Copy link

commented Nov 26, 2018

has this change already been merged in some version? We have a WF14 project using JavaEE 8, so no way to go back to version < WF13. Exist some pacaging install for wildlfy?(cli scripts + modules strcutres and pkgs)

@kifj

This comment has been minimized.

Copy link
Author

commented Nov 26, 2018

check release 7.10 which is announced to be released for Friday; last alpha includes already a WF 14 distro build

@phija

This comment has been minimized.

Copy link

commented Dec 10, 2018

Hi kifj,

where can I get this WF 14 release of Camunda? At https://camunda.org/release/camunda-bpm/ I only see these:
image

@koevskinikola

This comment has been minimized.

Copy link
Member

commented Dec 10, 2018

Hi @phija,

From 7.10 onwards we will release Camunda BPM only with the latest WildFly version. That's why we stopped appending WildFly version numbers to the name. You can see wildfly8, wildfly10 and wildfly11 because in previous releases we provided separate distros for them.

Cheers,
Nikola

@phija

This comment has been minimized.

Copy link

commented Dec 11, 2018

Thank you guys!

@alacambra

This comment has been minimized.

Copy link

commented Dec 11, 2018

Exists a bundle with the required modules an a cli script that can be applied to new versions?

@koevskinikola

This comment has been minimized.

Copy link
Member

commented Dec 11, 2018

Hi @alacambra,

The newest version of WildFly when Camunda BPM 7.10 came out on 30.11.2018 was WildFly 14, so Camunda BPM 7.10 is compatible with WildFly versions up to 14.

You can transfer the required modules from the available WildFly distro. They will work with WildFly versions 10-14 (WildFly 9 is not supported). If you want to use WildFly 8, you will need to download the modules as a separate archive. You can find the instructions on how to do a manual install (and the link to the WildFly 8 modules) here.

WildFly 15 was just recently released, and we will add support for it, and any new version that comes out (and we have enough time to make sure that everything works) before the 7.11 release of Camunda BPM.

Best,
Nikola

@alacambra

This comment has been minimized.

Copy link

commented Dec 11, 2018

Thanks @koevskinikola. Is somewhere written which are the exact needed modules? The reason why I am looking for that is because it looks like that the jaeger tracing modules has something buggy that ends up with slow redeployments (about 30s). I found that WF14 was buggy but has been fixed in some nightbuild but of course I need to reinstall the modules.

"12:51:38,976 WARN [io.jaegertracing.internal.senders.SenderResolver] (ServerService Thread Pool -- 132) No suitable sender found. Using NoopSender, meaning that data will not be sent anywhere!
12:52:08,999 INFO [io.jaegertracing.Configuration] (ServerService Thread Pool -- 132) Initialized tracer=JaegerTracer(version=Java-0.30.6, serviceName=camunda-archetype-demo.war, reporter=RemoteReporter(sender=NoopSender(), closeEnqueueTimeout=1000), sampler=RemoteControlledSampler(maxOperations=2000, manager=HttpSamplingManager(hostPort=localhost:5778), sampler=ProbabilisticSampler(tags={sampler.type=probabilistic, sampler.param=0.001})), tags={hostname=Alberts-MacBook-Pro.local, jaeger.version=Java-0.30.6, ip=192.168.1.24}, zipkinSharedRpcSpan=false, expandExceptionLogs=false)
12:52:09,011 INFO [org.jboss.resteasy.resteasy_jaxrs.i18n] (ServerService Thread Pool -- 132) RESTEASY002225: Deploying javax.ws.rs.core.Application: class ..."

Thanks for your help!

@koevskinikola

This comment has been minimized.

Copy link
Member

commented Dec 11, 2018

@alacambra, the installation guide specifies where they are. You can also see them in the camunda-wildfly8-modules archive, the modules are the same, just built for WF8.

In any case, it would be better if you post a help request in the forum, you'll get more input than in a closed PR.

Cheers,
Nikola

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.