Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAM-11231: Set ProcessDefinitionQueryDto.java attributes as protected. #605

Merged
merged 1 commit into from Jan 3, 2020
Merged

CAM-11231: Set ProcessDefinitionQueryDto.java attributes as protected. #605

merged 1 commit into from Jan 3, 2020

Conversation

gbarco
Copy link
Contributor

@gbarco gbarco commented Jan 3, 2020 •
edited by pull-request-badge bot

CAM-11231

  • Allow for extensibility similar to org.camunda.bpm.engine.rest.dto.runtime.modification.ProcessInstanceModificationInstructionDto, org.camunda.bpm.engine.rest.dto.runtime.StartProcessInstanceDto and many others.
  • Some uses are builders extending the class to either allow full configuration or setting user selected defaults, facades, factories or integrations with search engines that need to create custom queries programmatically.

@claassistantio
Copy link

claassistantio commented Jan 3, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@koevskinikola koevskinikola self-assigned this Jan 3, 2020
@koevskinikola koevskinikola changed the title Set ProcessDefinitionQueryDto.java attributes as protected. CAM-11231: Set ProcessDefinitionQueryDto.java attributes as protected. Jan 3, 2020
@koevskinikola
Copy link
Member

Hi @gbarco ,

Thank you for your contribution. Code looks good to me, I'll be merging it asap.

Cheers,
Nikola

@koevskinikola koevskinikola merged commit 8515eee into camunda:master Jan 3, 2020
@gbarco
Copy link
Contributor Author

gbarco commented Jan 4, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koevskinikola koevskinikola koevskinikola approved these changes

Assignees

@koevskinikola koevskinikola

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gbarco @claassistantio @koevskinikola