Feature: CAM-4069 I can set custom request headers using the HTTP-Client in JS SDK

[lightswitch05]

I need custom headers to allow authentication through a gateway. I saw there was already an open ticket for this feature: CAM-4069

Example usage:

var sdkClient = new CamSDK.Client({
    apiUri: 'http://example.com:8080/engine-rest',
    mock: false,
    headers: {'X-Requested-With': 'AngularJs'}
});

[SebastianStamm]

Thank you for the pull request! The code itself looks fine, but it would be awesome if you could provide some test cases for this feature.

[lightswitch05]

I agree that tests are needed. Unfortunately the current mocking strategy for tests makes it impossible to test anything in HttpClient

[SebastianStamm]

Then we should have a look at how we do the testing to make it possible :)

We are currently busy finishing the 7.4 release, but should be able to have a look at it next month.

[lightswitch05]

My vote is to use superagent-mock and completly remove HttpClientMock, but that would take more time then I have to spend on this. If this route were taken, it would allow more tests to be added involving promises for my other pull request.

This was a pretty urgent requirement for us, so we're going to be using it already, but that doesn't really count as testing.

[meyerdan]

+1 for removing the HttpClientMock

[SebastianStamm]

I updated superagent and replaced the mocking strategy with superagent-mock. I also added a small utility to test the header before sending it.

Merged with 3352110