Skip to content

feat: canonicals(7.18) -- correctly fix sitemap & apply rel=canonical strategy to 7.18 branch #1345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 15, 2022

Conversation

pepopowitz
Copy link
Contributor

Part of https://github.com/camunda/product-hub/issues/232.

This is a second attempt at #1336.

  1. Updates the theme based on feat (SEO): only use absolute URLs in sitemap and link rel=canonical camunda-docs-theme#33
  2. Specifies a canonicalBasePath config setting for proper sitemap & rel=canonical generation

Proof that the sitemap gets generated with absolute URLs

I ran a build locally and this is the generated sitemap:

image

Proof that pages are generated with a versionless rel=canonical

I ran a build locally and this is the generated page for /manual/7.18/user-guide/security/:

image

@pepopowitz
Copy link
Contributor Author

Merging this sans feedback so we can get it out there, but happy to come back and address any.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant