New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External labels cannot be deleted (clearing the text) #243

Closed
nikku opened this Issue Mar 30, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@nikku
Member

nikku commented Mar 30, 2016

Users assume that deleting an external label unsets the name of an element (cf. forum).

Gets adressed via bpmn-io/bpmn-js#503

@nikku nikku added this to the Backlog milestone Mar 30, 2016

@nikku nikku added the backlog label Feb 14, 2018

@nikku nikku removed this from the Backlog milestone Feb 14, 2018

@nikku nikku added this to the M21 milestone Apr 23, 2018

@nikku nikku added ready and removed backlog labels Apr 23, 2018

@philippfromme philippfromme added in progress and removed ready labels Apr 26, 2018

@philippfromme philippfromme self-assigned this Apr 26, 2018

@nikku nikku modified the milestones: M21, M22 Apr 26, 2018

philippfromme added a commit to bpmn-io/diagram-js that referenced this issue Apr 30, 2018

philippfromme added a commit to bpmn-io/bpmn-js that referenced this issue Apr 30, 2018

philippfromme added a commit to bpmn-io/bpmn-js that referenced this issue Apr 30, 2018

philippfromme added a commit to bpmn-io/bpmn-js that referenced this issue May 2, 2018

philippfromme added a commit to bpmn-io/bpmn-js that referenced this issue May 3, 2018

philippfromme added a commit to bpmn-io/bpmn-js that referenced this issue May 3, 2018

@philippfromme philippfromme assigned nikku and unassigned philippfromme May 3, 2018

@philippfromme

This comment has been minimized.

Contributor

philippfromme commented May 3, 2018

Copy and paste tests are skipped due to bugs that need a bigger refactoring.

philippfromme added a commit to bpmn-io/bpmn-js that referenced this issue May 3, 2018

philippfromme added a commit to bpmn-io/bpmn-js that referenced this issue May 3, 2018

philippfromme added a commit to bpmn-io/bpmn-js that referenced this issue May 3, 2018

philippfromme added a commit to bpmn-io/bpmn-js that referenced this issue May 3, 2018

nikku added a commit to bpmn-io/bpmn-js that referenced this issue May 3, 2018

@nikku

This comment has been minimized.

Member

nikku commented May 4, 2018

What is our plan regarding copy and paste now? My guess is you should create issues for the things that we still need to refactor to complete this ticket. Or is it broken in a sense that it is still somewhat usable and no change is required?

@nikku

This comment has been minimized.

Member

nikku commented May 4, 2018

I've added a few comments on the implementation. For bigger issues such as this one it probably makes sense to file a PR (for better discussion support).

nikku added a commit to bpmn-io/bpmn-js that referenced this issue May 4, 2018

philippfromme added a commit to bpmn-io/bpmn-js that referenced this issue May 7, 2018

philippfromme added a commit to bpmn-io/bpmn-js that referenced this issue May 7, 2018

nikku added a commit to bpmn-io/bpmn-js that referenced this issue May 16, 2018

nikku added a commit to bpmn-io/bpmn-js that referenced this issue May 16, 2018

nikku added a commit to bpmn-io/bpmn-js that referenced this issue May 24, 2018

nikku added a commit to bpmn-io/bpmn-js that referenced this issue May 24, 2018

@nikku nikku closed this in 230a10c May 29, 2018

@wafflebot wafflebot bot removed the needs review label May 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment